From 3118294b3fb232d378a26c7ba2084afbbee486e0 Mon Sep 17 00:00:00 2001
From: YannC <ycoornaert@kestra.io>
Date: Fri, 7 Feb 2025 09:27:14 +0100
Subject: [PATCH] fix(): correct usage of paths-filter action

---
 .github/actions/action-frontend-test/action.yml | 9 ++++++---
 .github/workflows/workflow-pr.yml               | 3 ++-
 2 files changed, 8 insertions(+), 4 deletions(-)

diff --git a/.github/actions/action-frontend-test/action.yml b/.github/actions/action-frontend-test/action.yml
index 1fbb610fa2d..7c16714b578 100644
--- a/.github/actions/action-frontend-test/action.yml
+++ b/.github/actions/action-frontend-test/action.yml
@@ -4,6 +4,9 @@ inputs:
   github-token:
     description: 'GitHub Token'
     required: true
+  codecov-token:
+    description: 'Codecov Token'
+    required: true
 
 
 runs:
@@ -12,7 +15,7 @@ runs:
     - id: checkout
       uses: actions/checkout@v4
       with:
-        ref: ${{ github.ref_name }} # Using ref_name in case translations has committed something
+        ref: ${{ github.ref }} # Using ref in case translations has committed something
 
     - name: Npm install
       shell: bash
@@ -22,7 +25,7 @@ runs:
     - name: Npm lint
       uses: reviewdog/action-eslint@v1
       with:
-        github_token: ${{ inputs.GITHUB_TOKEN }}
+        github_token: ${{ inputs.github-token }}
         reporter: github-pr-review # Change reporter.
         workdir: "ui"
 
@@ -30,7 +33,7 @@ runs:
       shell: bash
       working-directory: ui
       env:
-        CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
+        CODECOV_TOKEN: ${{ inputs.codecov-token }}
       run: npm run build
 
     - name: Run front-end unit tests
diff --git a/.github/workflows/workflow-pr.yml b/.github/workflows/workflow-pr.yml
index 9a2dd0ac723..b93cacbff31 100644
--- a/.github/workflows/workflow-pr.yml
+++ b/.github/workflows/workflow-pr.yml
@@ -61,6 +61,7 @@ jobs:
         uses: ./.github/actions/action-frontend-test
         with:
           github-token: ${{ secrets.GITHUB_TOKEN }}
+          codecov-token: ${{ secrets.CODECOV_TOKEN }}
 
   backend:
     name: 'Check Backend'
@@ -80,7 +81,7 @@ jobs:
           google-service-account: ${{ secrets.GOOGLE_SERVICE_ACCOUNT }}
 
   build-artifacts:
-    if: "needs.file-changes.outputs.backend == 'true' || needs.file-changes.outputs.ui == 'true'"
+    if: ${{ needs.file-changes.outputs.backend == 'true' || needs.file-changes.outputs.ui == 'true' }}
     name: Build artifacts
     runs-on: ubuntu-latest
     steps: