nmcli: team config empty error

[AlexMorra]

Related:
#654

Missed the check with missing configuration (team.config)

team.config: --

team.config is always a json string, but the configuration may not be filled in.

   item['team_config'] = json.loads(''.join(team_config_value))
                          ~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^

---

There is also another json field, team-port.config.
This is an related (child) Ethernet connection for the Team connection.

connection.id:                          team1
connection.uuid:                        a85e0eba-7140-4963-963d-ca9a0f6516ed
connection.stable-id:                   --
connection.type:                        802-3-ethernet
connection.interface-name:              --
connection.autoconnect:                 yes
connection.autoconnect-priority:        0
connection.autoconnect-retries:         -1 (default)
connection.multi-connect:               0 (default)
connection.auth-retries:                -1
connection.timestamp:                   0
connection.read-only:                   no
connection.permissions:                 --
connection.zone:                        --
connection.master:                      d229f048-5c75-40f4-a7ff-61174546c506
connection.slave-type:                  team
connection.autoconnect-slaves:          -1 (default)
connection.secondaries:                 --
connection.gateway-ping-timeout:        0
connection.metered:                     unknown
connection.lldp:                        default
connection.mdns:                        -1 (default)
connection.llmnr:                       -1 (default)
connection.dns-over-tls:                -1 (default)
connection.wait-device-timeout:         -1
802-3-ethernet.port:                    --
802-3-ethernet.speed:                   0
802-3-ethernet.duplex:                  --
802-3-ethernet.auto-negotiate:          no
802-3-ethernet.mac-address:             --
802-3-ethernet.cloned-mac-address:      --
802-3-ethernet.generate-mac-address-mask:--
802-3-ethernet.mac-address-blacklist:   --
802-3-ethernet.mtu:                     auto
802-3-ethernet.s390-subchannels:        --
802-3-ethernet.s390-nettype:            --
802-3-ethernet.s390-options:            --
802-3-ethernet.wake-on-lan:             default
802-3-ethernet.wake-on-lan-password:    --
802-3-ethernet.accept-all-mac-addresses:-1 (default)
team-port.config:                       {
    "queue_id": 0,
    "prio": 0,
    "lacp_prio": 0,
    "lacp_key": 0
}
team-port.queue-id:                     0 (default)
team-port.prio:                         0 (unset)
team-port.sticky:                       no
team-port.lacp-prio:                    0
team-port.lacp-key:                     0 (default)
team-port.link-watchers:                --

According to the nmtui interface, it is also json string. It is empty by default.

[kellyjonbrazil]

Thanks - shouldn't be too difficult to fix these.

[kellyjonbrazil]

I have a fix for the new team-port.config field and the -- blank value in dev. Please test with this file in your plugin directory:

https://github.com/kellyjonbrazil/jc/blob/dev/jc/parsers/nmcli.py

• Linux/unix: $HOME/.local/share/jc/jcparsers
• macOS: $HOME/Library/Application Support/jc/jcparsers
• Windows: $LOCALAPPDATA\jc\jc\jcparsers

Thanks!

[AlexMorra]

Works as expected, excellent!
I've checked several possible options

port config

team-port.config:                       {
    "prio": 0,
    "lacp_prio": 0,
    "link_watch": {
        "name": "ethtool",
        "delay_up": 0,
        "delay_down": 0
    }
}
team-port.queue-id:                     -1 (unset)

empty port config

802-3-ethernet.accept-all-mac-addresses:-1 (default)
team-port.config:                       --
team-port.queue-id:                     -1 (unset)

team config

ipv6.token:                             --
team.config:                            {
    "notify_peers": {
        "count": 0,
        "interval": 0
    },
    "mcast_rejoin": {
        "count": 0,
        "interval": 0
    },
    "runner": {
        "name": "broadcast"
    },
    "link_watch": {
        "name": "ethtool"
    }
}
team.notify-peers-count:                0 (disabled)

empty team config

ipv6.token:                             --
team.config:                            --
team.notify-peers-count:                -1 (unset)