Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

store$contains_item for sub_paths? #72

Open
keller-mark opened this issue May 7, 2024 · 1 comment
Open

store$contains_item for sub_paths? #72

keller-mark opened this issue May 7, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@keller-mark
Copy link
Owner

User story

Currently, contains_item returns false for parts of keys. For example if there is something at /foo/bar/.zattrs it will only return true for the full path and not necessarily /foo only

Preferred solution

Possible alternatives

@keller-mark keller-mark added the enhancement New feature or request label May 7, 2024
@keller-mark
Copy link
Owner Author

keller-mark commented Jun 18, 2024

Behavior should be the same between all stores (e.g., MemoryStore and DirectoryStore) - currently I think it is not as file.exists will return TRUE for a directory.

Also, behavior should be consistent with Python. If needed, we can add an argument like $contains_item(include_ancestors = FALSE)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant