Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add flag to make the deregister target type configurable #212

Open
ZihanJiang96 opened this issue Jul 17, 2024 · 0 comments
Open

add flag to make the deregister target type configurable #212

ZihanJiang96 opened this issue Jul 17, 2024 · 0 comments

Comments

@ZihanJiang96
Copy link
Member

ZihanJiang96 commented Jul 17, 2024

Is this a BUG REPORT or FEATURE REQUEST?:

FEATURE REQUEST

What happened:

In lifecycle-manager during node termination with --with-deregister flag, we always check both ClassicELB and TargetGroup to deregister the node from load-balancer we will make many Describe calls on TargetGroup.

This is a valid use-case if we are using ec2 nodes as the Load-balancer targets.
But if we are using flat network, the TargetGroup is managed by the ALB ingress controller, in this case, we don't need to describe TargetGroup to deregister the node.

What you expected to happen:

https://github.com/keikoproj/lifecycle-manager/blob/master/pkg/service/server.go#L306-L335

It is better to introduce a new flag like --deregister-target-type which can take comma-separated values like ClassicELB and TargetGroup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant