Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node-reaper to handle longer time node drain case #67

Open
figo opened this issue May 31, 2022 · 1 comment
Open

node-reaper to handle longer time node drain case #67

figo opened this issue May 31, 2022 · 1 comment

Comments

@figo
Copy link

figo commented May 31, 2022

Is this a BUG REPORT or FEATURE REQUEST?:
feature request

What happened:
Currently, when node drain timeout, node-reaper will mark the node uncordon, and then try to drain it again in next round (approx in next 10m )

for the node that has pod take long time to be evicted, it is possible that the same node can be under constant drain.

What you expected to happen:

set node drain timeout to 1hr or longer if possible.

How to reproduce it (as minimally and precisely as possible):
run the node-reaper with pod that take more than 10m to be evicted

Anything else we need to know?:
N/A

Environment:
N/A

  • Kubernetes version:
    N/A
kubectl version -o yaml

Other debugging information (if applicable):

  • relevant logs:
kubectl logs <governor-pod>
@eytan-avisror
Copy link
Collaborator

There is already a --drain-timeout flag that allows changing the default 600s, but it would be global to all namespaces.
In this case it seems we want a feature to be able to selectively change this for a specific namespace that might want more than 600s rather than changing it for everyone?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants