Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase test coverage #6

Open
eytan-avisror opened this issue Aug 12, 2019 · 4 comments
Open

Increase test coverage #6

eytan-avisror opened this issue Aug 12, 2019 · 4 comments
Labels
enhancement New feature or request hacktoberfest testing
Milestone
0.2.0

Comments

@eytan-avisror
Copy link
Collaborator

unit-test coverage is around 50%, should get it >75% at the very least.
@eytan-avisror eytan-avisror added enhancement New feature or request testing labels Aug 12, 2019
@eytan-avisror eytan-avisror added this to the 0.2.0 milestone Aug 12, 2019
@pratyushprakash
Copy link
Contributor

Can I take this up?

@eytan-avisror
Copy link
Collaborator Author

Hi @pratyushprakash
Thanks for your interest in this, I am afraid we should probably do #14 before doing this as it will probably break some tests.

If you'd like we are happy to take such changes in tests for pod-reaper which is not expecting any refactor soon, however for node-reaper we should probably wait until #14 is done - I was planning on working on it soon.

@pratyushprakash
Copy link
Contributor

@eytan-avisror How about a PR for just the pod-reaper? I can help out in #14 too if you want.

@eytan-avisror
Copy link
Collaborator Author

Thanks @pratyushprakash feel free to send a PR with unit test improvements for pod-reaper.
As for #14 I've already started working on it, I'll send a PR in a few days and we'll see if there is more help needed there.

One issue that may be interesting and we really need is #7 - would be awesome if you can make any contributions there! take a look - we can discuss further on that issue if you find it interesting.

@tekenstam tekenstam mentioned this issue Oct 17, 2019
Merged
pratyushprakash added a commit to pratyushprakash/governor that referenced this issue Oct 24, 2019
@pratyushprakash
Increase test coverage for podreaper (keikoproj#6)
1710590 
* Refactor `Run` to take in `ReaperContext`

* Refactor podreaper command line to build a `ReaperContext`
eytan-avisror pushed a commit that referenced this issue Oct 29, 2019
@pratyushprakash @eytan-avisror
Increase test coverage for podreaper (#6) (#22)
0b5d58b 
* Refactor `Run` to take in `ReaperContext`

* Refactor podreaper command line to build a `ReaperContext`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request hacktoberfest testing
Projects
None yet
Milestone
0.2.0
Development

No branches or pull requests
3 participants
@tekenstam @pratyushprakash @eytan-avisror