Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong use of BeerPowder #1

Open
yonoslaw opened this issue May 17, 2016 · 1 comment
Open

Wrong use of BeerPowder #1

yonoslaw opened this issue May 17, 2016 · 1 comment

Comments

@yonoslaw
Copy link

Hi!
Your code is great, very clean. I was working on a clouds shader for some days now but just as it was almost ready I found this. I found here some things I was missing in my version, thanks for sharing this.
There is a small bug in your code. You are using the BeerPowder in a wrong way, it should be used for clouds pointing away from the sun. Now the BeerPowder makes a ugly black silhouettes around clouds that occlude sun. The second thing is the light loop. I could tune it fine with just <10 steps and without the random noise. I thinks the light steps should be much smaller.

@keijiro
Copy link
Owner

keijiro commented May 17, 2016

Thanks for the advice! This is just a quick and dirty hack at the moment... I should improve a lot for use in real applications. I'll look into the points you mentioned when I get time for improvement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants