Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: add more unit tests for getAllocatedMemoryUnits involving Cairo Program #386

Open
tcoratger opened this issue Feb 20, 2024 · 3 comments
Assignees
Labels

Comments

@tcoratger
Copy link
Collaborator

Issue Description

After ensuring that the Program structure is properly handled by our Cairo runner, we will have to enhance the test coverage for the getAllocatedMemoryUnits method within the BuiltinRunner union(enum).

To achieve this, we need to add more unit tests covering various scenarios and edge cases. These tests will validate the behavior of the getAllocatedMemoryUnits method under different conditions, ensuring robustness and reliability.

The relevant code section for the getAllocatedMemoryUnits method can be found here:

https://github.com/lambdaclass/cairo-vm/blob/4ea224a1068b43aaa3899d24e834475106e8a78f/vm/src/vm/runners/builtin_runner/mod.rs#L793-L971

Action Items

  • Add unit tests for getAllocatedMemoryUnits method in BuiltinRunner union(enum).
  • Ensure comprehensive coverage of different scenarios and edge cases.
  • Validate the behavior of the method under varying conditions.
@oxlime
Copy link
Contributor

oxlime commented Feb 22, 2024

would like this one

@tcoratger
Copy link
Collaborator Author

would like this one

@oxlime Assigned

Copy link

There hasn't been any activity on this issue recently, and in order to prioritize active issues, it will be marked as stale.
Please make sure to update to the latest version and check if that solves the issue. Let us know if that works for you by leaving a 👍
Because this issue is marked as stale, it will be closed and locked in 7 days if no further activity occurs.
Thank you for your contributions!

@github-actions github-actions bot added the stale label Mar 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants