Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat] Add SIGTERM handling to scripts/data/client.py #295

Open
maciejka opened this issue Nov 5, 2024 · 4 comments · May be fixed by #297
Open

[feat] Add SIGTERM handling to scripts/data/client.py #295

maciejka opened this issue Nov 5, 2024 · 4 comments · May be fixed by #297
Assignees
@raizo07
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@maciejka
Copy link
Collaborator

maciejka commented Nov 5, 2024

Currently it takes several Ctrl-C to stop scripts/data/client.py:
image
Add proper SIGTERM handling to the script so it behaves as expected. Make sure no unnecessary exceptions are written to the logs.
@maciejka maciejka added good first issue Good for newcomers help wanted Extra attention is needed labels Nov 5, 2024
@raizo07
Copy link
Contributor

raizo07 commented Nov 5, 2024 •
edited
Loading

Can I work on this @maciejka

ETA: 15 hours

@tosoham
Copy link

tosoham commented Nov 5, 2024

I am a Python dev who have significantly contributed in this platform in python issues. I am also new to this project and anticipates assignment. Can I be assigned to this?
I will approach this problem by adding proper SIGTERM handling so that several Crl + C is not require to stop the running scripts. Also will take care of no unnecessary exceptions are written to the logs.

@ShantelPeters
Copy link

Hi @maciejka
Please can I be assigned to this issue

@GideonBature
Copy link

Can I work on this issue please?

@raizo07 raizo07 linked a pull request Nov 5, 2024 that will close this issue
Open
3 tasks
@maciejka maciejka mentioned this issue Nov 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@raizo07 raizo07

Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Add SIGTERM handling raizo07/raito
5 participants
@maciejka @raizo07 @GideonBature @tosoham @ShantelPeters