Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue when depends var is put inside of function #159

Open
MG2R opened this issue Jul 12, 2017 · 0 comments
Open

Issue when depends var is put inside of function #159

MG2R opened this issue Jul 12, 2017 · 0 comments

Comments

@MG2R
Copy link

MG2R commented Jul 12, 2017

My issue is with the sickgear package, where the maintainer has put the "depends" variable in the package() function. packer simply sources the PKGBUILD files and then uses variables in its env to filter the dependencies. This creates an issue for PKGBUILDs like sickgear's, as the package() function isn't actually execute, so the "depends" variable isn't sourced into the environment.

@keenerd not quite sure how to best solve this. I get the maintainers putting the depends array inside the package function. People not actually wishing to package shouldn't have to care about dependencies until the package() function is actually called. The AUR also seems to support this (unless dependency information is entered manually). Are these issues you're willing to catch in the code, or do you think package maintainers should put their depends variables in the top scope of their PKGBUILDs?

@MG2R MG2R changed the title Issue when depends var is put inside of Issue when depends var is put inside of function Jul 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant