refactor liklus scaler #6433
Open
refactor liklus scaler #6433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Omer Aplatony <[email protected]>
omerap12
force-pushed
the
refactor_liklus_scaler
branch
from
cfe52d7 to
56f8d4a
Compare
wozniakjan
reviewed
Dec 20, 2024
pkg/scalers/liiklus_scaler.go
Outdated
Comment on lines
165
to
172
| switch { | ||
| case config.TriggerMetadata["topic"] == "": | ||
| case meta.Topic == "": | ||
| return nil, ErrLiiklusNoTopic | ||
| case config.TriggerMetadata["address"] == "": | ||
| case meta.Address == "": | ||
| return nil, ErrLiiklusNoAddress | ||
| case config.TriggerMetadata["group"] == "": | ||
| case meta.Group == "": | ||
| return nil, ErrLiiklusNoGroup | ||
| } |
There was a problem hiding this comment.
I think this should be safe to remove because Topic, Address, and Group are not marked as optional in the field tags so the TypedConfig parsing will throw an error
There was a problem hiding this comment.
Yes, I agree. fixed in: 4934fd0
pkg/scalers/liiklus_scaler_test.go
Outdated
| if err != nil { | ||
| t.Fatal("Could not parse metadata:", err) | ||
| } | ||
| meta.triggerIndex = testData.triggerIndex |
There was a problem hiding this comment.
tests shouldn't modify the meta from parseLiiklusMetadata
| activationLagThreshold: activationLagThreshold, | ||
| triggerIndex: config.TriggerIndex, | ||
| }, nil | ||
| return meta, nil |
There was a problem hiding this comment.
I think this is the place that should populate meta.triggerIndex
Suggested change
| return meta, nil | |
| meta.triggerIndex = config.TriggerIndex | |
| return meta, nil |
Signed-off-by: Omer Aplatony <[email protected]>
JorTurFer
reviewed
Dec 22, 2024
I only use them in _test.go, so I believe they can be removed. |
Signed-off-by: Omer Aplatony <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide a description of what has been changed
Checklist
Fixes #
Relates to #5797