Skip to content

nuke_display is missing container.data for webp #853

@sureshjoshi

Description

@sureshjoshi

I was working on local animated webp support and I noticed that I was unable to get container.data from nuke_display

override func nuke_display(image: UIImage?, data: Data?) {
  guard let image else {
      self.image = nil
      return
  }
  if let data {
    // never reached
    ...

The most barebones hack here gets this working and I can enable animated webp: main...sureshjoshi:Nuke:animated-webp-infra

I'll happily take a crack at a PR - but might need suggestions on where I might get caught up in tricky bugs, as I've only ever run very specific Nuke workflows

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions