Skip to content

Commit d147af1

Browse files
authored
Merge pull request cms-sw#36569 from bsunanda/Run3-gex105B
Run3-gex105B Use ESGetToken in SimTracker/TrackerMaterialAnalysis
2 parents 40babbf + 3a13c22 commit d147af1

File tree

2 files changed

+15
-12
lines changed

2 files changed

+15
-12
lines changed

SimTracker/TrackerMaterialAnalysis/plugins/ListGroups.cc

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,9 @@ class ListGroups : public edm::one::EDAnalyzer<> {
8787
void fillGradient();
8888
std::vector<std::pair<std::shared_ptr<TLine>, std::shared_ptr<TText> > > overlayEtaReferences();
8989
void produceAndSaveSummaryPlot(const edm::EventSetup &);
90-
bool m_saveSummaryPlot;
90+
91+
const bool m_saveSummaryPlot;
92+
const edm::ESGetToken<DDCompactView, IdealGeometryRecord> ddToken_;
9193
std::vector<TH2F *> m_plots;
9294
std::set<std::string> m_group_names;
9395
std::vector<MaterialAccountingGroup *> m_groups;
@@ -107,8 +109,9 @@ class ListGroups : public edm::one::EDAnalyzer<> {
107109
std::map<std::string, std::pair<float, float> > m_values;
108110
};
109111

110-
ListGroups::ListGroups(const edm::ParameterSet &iPSet) {
111-
m_saveSummaryPlot = iPSet.getUntrackedParameter<bool>("SaveSummaryPlot");
112+
ListGroups::ListGroups(const edm::ParameterSet &iPSet)
113+
: m_saveSummaryPlot(iPSet.getUntrackedParameter<bool>("SaveSummaryPlot")),
114+
ddToken_(esConsumes<DDCompactView, IdealGeometryRecord>()) {
112115
m_plots.clear();
113116
m_groups.clear();
114117
TColor::InitializeColors();
@@ -312,8 +315,7 @@ void ListGroups::produceAndSaveSummaryPlot(const edm::EventSetup &setup) {
312315
kOpenCross,
313316
kFullStar};
314317

315-
edm::ESTransientHandle<DDCompactView> hDdd;
316-
setup.get<IdealGeometryRecord>().get(hDdd);
318+
edm::ESTransientHandle<DDCompactView> hDdd = setup.getTransientHandle(ddToken_);
317319

318320
for (const auto &n : m_group_names) {
319321
m_groups.push_back(new MaterialAccountingGroup(n, *hDdd));
@@ -424,8 +426,7 @@ void ListGroups::produceAndSaveSummaryPlot(const edm::EventSetup &setup) {
424426
}
425427

426428
void ListGroups::analyze(const edm::Event &evt, const edm::EventSetup &setup) {
427-
edm::ESTransientHandle<DDCompactView> hDdd;
428-
setup.get<IdealGeometryRecord>().get(hDdd);
429+
edm::ESTransientHandle<DDCompactView> hDdd = setup.getTransientHandle(ddToken_);
429430

430431
DDSpecificsHasNamedValueFilter filter{"TrackingMaterialGroup"};
431432
DDFilteredView fv(*hDdd, filter);

SimTracker/TrackerMaterialAnalysis/plugins/dd4hep/DD4hep_ListGroups.cc

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -42,9 +42,11 @@ class DD4hep_ListGroups : public edm::one::EDAnalyzer<> {
4242
void analyze(const edm::Event &, const edm::EventSetup &) override;
4343
void beginJob() override {}
4444
void endJob() override;
45+
4546
const edm::ESInputTag m_tag;
47+
const bool m_saveSummaryPlot;
48+
const edm::ESGetToken<cms::DDCompactView, IdealGeometryRecord> ddToken_;
4649

47-
bool m_saveSummaryPlot;
4850
std::vector<TH2F *> m_plots;
4951
std::set<std::string_view> m_group_names;
5052
std::vector<unsigned int> m_color;
@@ -62,8 +64,9 @@ class DD4hep_ListGroups : public edm::one::EDAnalyzer<> {
6264
#include "DD4hep_ListGroupsMaterialDifference.h"
6365

6466
DD4hep_ListGroups::DD4hep_ListGroups(const edm::ParameterSet &iConfig)
65-
: m_tag(iConfig.getParameter<edm::ESInputTag>("DDDetector")) {
66-
m_saveSummaryPlot = iConfig.getUntrackedParameter<bool>("SaveSummaryPlot");
67+
: m_tag(iConfig.getParameter<edm::ESInputTag>("DDDetector")),
68+
m_saveSummaryPlot(iConfig.getUntrackedParameter<bool>("SaveSummaryPlot")),
69+
ddToken_(esConsumes<cms::DDCompactView, IdealGeometryRecord>(m_tag)) {
6770
m_plots.clear();
6871
m_groups.clear();
6972
TColor::InitializeColors();
@@ -361,8 +364,7 @@ std::vector<std::pair<std::shared_ptr<TLine>, std::shared_ptr<TText>>> DD4hep_Li
361364
}
362365

363366
void DD4hep_ListGroups::analyze(const edm::Event &evt, const edm::EventSetup &setup) {
364-
edm::ESTransientHandle<cms::DDCompactView> cpv;
365-
setup.get<IdealGeometryRecord>().get(m_tag, cpv);
367+
edm::ESTransientHandle<cms::DDCompactView> cpv = setup.getTransientHandle(ddToken_);
366368
cms::DDFilter filter("TrackingMaterialGroup", "");
367369
cms::DDFilteredView fv(*cpv, filter);
368370

0 commit comments

Comments
 (0)