Drop type specs in RecoB and RecoEgamma

Author: NiharSaha

Validation/RecoB/python/BDHadronTrackMonitoring_cfi.py

@@ -19,4 +19,4 @@
 
 
 BDHadronTrackMonitoringHarvest = DQMEDHarvester("BDHadronTrackMonitoringHarvester"
-								)
+                               )

Validation/RecoB/python/BDHadronTrackValidation_cff.py

@@ -4,8 +4,8 @@
 # and rerun PAT (because sometimes validation is ran without PAT sequence enables)
 from PhysicsTools.PatAlgos.producersLayer1.jetProducer_cff import *
 patJetsBDHadron = patJets.clone(
-    tagInfoSources = cms.VInputTag(cms.InputTag('pfImpactParameterTagInfos')),
-    addTagInfos = cms.bool(True)
+    tagInfoSources = cms.VInputTag('pfImpactParameterTagInfos'),
+    addTagInfos = True
 )
 
 # my analyzer

Validation/RecoEgamma/python/electronIsoFromDeps_cff.py

@@ -10,10 +10,11 @@
 eleIsoDepositEcalFromHitsFull = eleIsoDepositEcalFromHits.clone()
 eleIsoDepositEcalFromHitsReduced = eleIsoDepositEcalFromHits.clone()
 
-eleIsoDepositEcalFromHitsFull.ExtractorPSet.barrelEcalHits = cms.InputTag("ecalRecHit","EcalRecHitsEB")
-eleIsoDepositEcalFromHitsFull.ExtractorPSet.endcapEcalHits = cms.InputTag("ecalRecHit","EcalRecHitsEE")
-eleIsoDepositEcalFromHitsReduced.ExtractorPSet.barrelEcalHits = cms.InputTag("reducedEcalRecHitsEB")
-eleIsoDepositEcalFromHitsReduced.ExtractorPSet.endcapEcalHits = cms.InputTag("reducedEcalRecHitsEE")
+eleIsoDepositEcalFromHitsFull.ExtractorPSet.barrelEcalHits = "ecalRecHit : EcalRecHitsEB"
+eleIsoDepositEcalFromHitsFull.ExtractorPSet.endcapEcalHits = "ecalRecHit : EcalRecHitsEE"
+eleIsoDepositEcalFromHitsReduced.ExtractorPSet.barrelEcalHits = "reducedEcalRecHitsEB"
+eleIsoDepositEcalFromHitsReduced.ExtractorPSet.endcapEcalHits = "reducedEcalRecHitsEE"
+
 
 # clone the value map producers for each DR
 
@@ -57,4 +58,4 @@
   eleIsoFromDepsEcalFromHitsByCrystalReduced04*
   eleIsoFromDepsHcalFromTowers03*
   eleIsoFromDepsHcalFromTowers04
-)
+)

Validation/RecoEgamma/python/electronValidationSequenceMiniAOD_cff.py

@@ -8,9 +8,10 @@
 from RecoParticleFlow.PFProducer.particleFlowEGamma_cff import egmElectronIsolationCITK as _egmElectronIsolationCITK
 from RecoParticleFlow.PFProducer.particleFlowEGamma_cff import *
 
-miniAODElectronIsolation = _egmElectronIsolationCITK.clone() 
-miniAODElectronIsolation.srcToIsolate = cms.InputTag("slimmedElectrons")
-miniAODElectronIsolation.srcForIsolationCone = cms.InputTag("packedPFCandidates")
+miniAODElectronIsolation = _egmElectronIsolationCITK.clone( 
+    srcToIsolate = "slimmedElectrons",
+    srcForIsolationCone = "packedPFCandidates"
+)
 
 electronValidationTaskMiniAOD = cms.Task(egmElectronIsolationCITK, miniAODElectronIsolation, ElectronIsolation)
 electronValidationSequenceMiniAOD = cms.Sequence(electronMcSignalValidatorMiniAOD, electronValidationTaskMiniAOD)

Validation/RecoEgamma/python/tkConvValidator_cfi.py

@@ -10,29 +10,29 @@
 trackAssociatorByHitsForConversionValidation.Cut_RecoToSim = 0.5
 
 from CommonTools.RecoAlgos.trackingParticleRefSelector_cfi import trackingParticleRefSelector as _trackingParticleRefSelector
-tpSelecForEfficiency = _trackingParticleRefSelector.clone()
-tpSelecForEfficiency.chargedOnly = True
-# trackingParticleSelector.pdgId = cms.vint32()
-tpSelecForEfficiency.tip = 120
-tpSelecForEfficiency.lip = 280
-tpSelecForEfficiency.signalOnly = False
-tpSelecForEfficiency.minRapidity = -2.5
-tpSelecForEfficiency.ptMin = 0.3
-tpSelecForEfficiency.maxRapidity = 2.5
-tpSelecForEfficiency.minHit = 0
-
-
-tpSelecForFakeRate = _trackingParticleRefSelector.clone()
-tpSelecForFakeRate.chargedOnly = True
-# trackingParticleSelector.pdgId = cms.vint32()
-tpSelecForFakeRate.tip = 120
-tpSelecForFakeRate.lip = 280
-tpSelecForFakeRate.signalOnly = False
-tpSelecForFakeRate.minRapidity = -2.5
-tpSelecForFakeRate.ptMin = 0.
-tpSelecForFakeRate.maxRapidity = 2.5
-tpSelecForFakeRate.minHit = 0
+tpSelecForEfficiency = _trackingParticleRefSelector.clone(
+    chargedOnly = True,
+    # trackingParticleSelector.pdgId = cms.vint32()
+    tip = 120,
+    lip = 280,
+    signalOnly = False,
+    minRapidity = -2.5,
+    ptMin = 0.3,
+    maxRapidity = 2.5,
+    minHit = 0
+)
 
+tpSelecForFakeRate = _trackingParticleRefSelector.clone(
+    chargedOnly = True,
+    # trackingParticleSelector.pdgId = cms.vint32()
+    tip = 120,
+    lip = 280,
+    signalOnly = False,
+    minRapidity = -2.5,
+    ptMin = 0.0,
+    maxRapidity = 2.5,
+    minHit = 0
+)
 
 
 from DQMServices.Core.DQMEDAnalyzer import DQMEDAnalyzer

Validation/RecoEgamma/python/tpSelection_cfi.py

@@ -1,15 +1,16 @@
 import FWCore.ParameterSet.Config as cms
 
 import PhysicsTools.RecoAlgos.trackingParticleSelector_cfi
-tpSelection = PhysicsTools.RecoAlgos.trackingParticleSelector_cfi.trackingParticleSelector.clone()
-tpSelection.chargedOnly = True
-# trackingParticleSelector.pdgId = cms.vint32()
-tpSelection.tip = 120
-tpSelection.lip = 280
-tpSelection.signalOnly = False
-tpSelection.minRapidity = -2.5
-tpSelection.ptMin = 1.
-tpSelection.maxRapidity = 2.5
-tpSelection.minHit = 0
+tpSelection = PhysicsTools.RecoAlgos.trackingParticleSelector_cfi.trackingParticleSelector.clone(
+    chargedOnly = True,
+    # trackingParticleSelector.pdgId = cms.vint32()
+    tip = 120,
+    lip = 280,
+    signalOnly = False,
+    minRapidity = -2.5,
+    ptMin = 1.0,
+    maxRapidity = 2.5,
+    minHit = 0
 
+)