-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KDL 1.0 Compliance #22
Comments
Hey @zkat ! Thanks for this - I've already started taking a look at the recent additions to the spec to plan out what I need to change - also looked against other implementations for test cases. One big recent change was the addition of types as a hint for values - I was debating how I should implement this and to what extent I should cast values according to the types (i.e. the Rust-based types like |
Honestly if I were you I would just include the type hints in your deserialized types and just leave it at that for now? You can also just use them to hint about whether to convert to float or int, imo, and that's all |
Makes perfect sense! OK, that's how I'll handle it for now. |
Hi! Since this was originally written, KDL has stabilized to 1.0.0. No further changes should be made to spec so it should be safe to update + finalize kdl-php to the 1.0 spec!
Please let me know if you have any questions or if there's anything I can do to help!
The text was updated successfully, but these errors were encountered: