Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toast offset should update when toast updates #51

Open
BlueGreenMagick opened this issue Aug 17, 2023 · 2 comments · May be fixed by #75
Open

Toast offset should update when toast updates #51

BlueGreenMagick opened this issue Aug 17, 2023 · 2 comments · May be fixed by #75

Comments

@BlueGreenMagick
Copy link

When a toast is modified, its height can change, which should update the toast offsets for all other toasts.

For example, in the below code the updated toast is stacked on top of another toast below.

toast.promise(promise, {
loading: 'Saving...',
success: `Settings saved! This message extends across multiple lines.`,
error: `Could not save. This message extends across multiple lines.`
});
@BlueGreenMagick
Copy link
Author

image

@kbrgl
Copy link
Owner

kbrgl commented Aug 18, 2023

Holy cow that's ugly. Thanks for reporting this issue, will investigate. I’m looking into moving to a flexbox based approach where I don't do manual offset calculations so that this issue doesn't come up.

@BlueGreenMagick BlueGreenMagick linked a pull request Aug 13, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants