add NSConn#EmitBinary helper (js: emitBinary)

kataras · Dec 10, 2019 · eb5c6fb · eb5c6fb
1 parent 7c3c769
commit eb5c6fb
Show file tree

Hide file tree

Showing 5 changed files with 7,803 additions and 18 deletions.
diff --git a/_examples/protobuf/browser/app.js b/_examples/protobuf/browser/app.js
@@ -31,16 +31,18 @@ function handleNamespaceConnectedConn(nsConn) {
         userMsg.setText(input);
 
         const body = userMsg.serializeBinary()
-        let msg = new neffos.Message();
-        msg.Namespace = "default";
-        msg.Event = "chat";
-        msg.Body = body;
-        msg.SetBinary = true;
-        nsConn.conn.write(msg);
+        // let msg = new neffos.Message();
+        // msg.Namespace = "default";
+        // msg.Event = "chat";
+        // msg.Body = body;
+        // msg.SetBinary = true;
+        // nsConn.conn.write(msg);
+        // ^ == 
+        nsConn.emitBinary("chat", body);
         //
         // OR: javascript side will check if body is binary,
         // and if it's it will convert it to valid utf-8 text before sending.
-        // To keep the data as they are, please prefer the above commented code (msg.SetBinary = true).
+        // To keep the data as they are, please prefer `emitBinary`.
         // nsConn.emit("chat", body);
         addMessage("Me: " + input);
     };

diff --git a/_examples/protobuf/browser/bundle.js b/_examples/protobuf/browser/bundle.js
diff --git a/_examples/protobuf/browser/package.json b/_examples/protobuf/browser/package.json
@@ -9,7 +9,7 @@
     },
     "dependencies": {
         "google-protobuf": "^3.11.1",
-        "neffos.js": "^0.1.24",
+        "neffos.js": "^0.1.25",
         "protobufjs": "~6.8.8"
     },
     "devDependencies": {

diff --git a/_examples/protobuf/main.go b/_examples/protobuf/main.go
@@ -169,7 +169,7 @@ func startClient() {
 	userMsg := &UserMessage{
 		Username: string(usernameBytes),
 		// only `Text` field is dynamic, therefore we can reuse this instance value,
-		// the `Text` field can be filled right before the `Conn#Write`, check below.
+		// the `Text` field can be filled right before the `c#EmitBinary`, check below.
 	}
 
 	fmt.Fprint(os.Stdout, ">> ")
@@ -199,12 +199,7 @@ func startClient() {
 			log.Fatal(err)
 		}
 
-		c.Conn.Write(neffos.Message{
-			Namespace: namespace,
-			Event:     "chat",
-			Body:      body,
-			SetBinary: true,
-		})
+		c.EmitBinary("chat", body)
 
 		fmt.Fprint(os.Stdout, ">> ")
 	}

diff --git a/conn_namespace.go b/conn_namespace.go
@@ -49,13 +49,23 @@ func (ns *NSConn) String() string {
 // Emit method sends a message to the remote side
 // with its `Message.Namespace` filled to this specific namespace.
 func (ns *NSConn) Emit(event string, body []byte) bool {
-	if ns == nil { // if for any reason Namespace() called without be available.
+	if ns == nil {
 		return false
 	}
 
 	return ns.Conn.Write(Message{Namespace: ns.namespace, Event: event, Body: body})
 }
 
+// EmitBinary acts like `Emit` but it sets the `Message.SetBinary` to true
+// and sends the data as binary, the receiver's Message in javascript-side is Uint8Array.
+func (ns *NSConn) EmitBinary(event string, body []byte) bool {
+	if ns == nil {
+		return false
+	}
+
+	return ns.Conn.Write(Message{Namespace: ns.namespace, Event: event, Body: body, SetBinary: true})
+}
+
 // Ask method writes a message to the remote side and blocks until a response or an error received.
 func (ns *NSConn) Ask(ctx context.Context, event string, body []byte) (Message, error) {
 	if ns == nil {