Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UPS add surcharges codes mapping #671

Closed
jacobshilitz opened this issue Sep 4, 2024 · 1 comment · Fixed by #681
Closed

UPS add surcharges codes mapping #671

jacobshilitz opened this issue Sep 4, 2024 · 1 comment · Fixed by #681

Comments

@jacobshilitz
Copy link
Collaborator

jacobshilitz commented Sep 4, 2024

currntly karrio API on ups shipment return

{
      "id": "rat_1431aa4bf52449438e6ed9320a141071",
      "object_type": "rate",
      "carrier_name": "ups",
      "carrier_id": "ups",
      "currency": "CAD",
      "service": "ups_express_ca",
      "total_charge": 23.38,
      "transit_days": 1,
      "extra_charges": [
        {
          "name": "Base charge",
          "amount": 64.67,
          "currency": "CAD"
        },
        {
          "name": "01",
          "amount": 0,
          "currency": "CAD"
        },
        {
          "name": "375",
          "amount": 3.41,
          "currency": "CAD"
        },
        {
          "name": "HST",
          "amount": 2.69,
          "currency": "CAD"
        }
      ],
      "meta": {
        "carrier": "ups",
        "carrier_connection_id": "car_711e19eddc164eaa80e12d34d36a215d",
        "ext": "ups",
        "rate_provider": "ups",
        "service_name": "UPS EXPRESS CA"
      },
      "test_mode": false
    },
    

we need to add this item-charges mapping

https://developer.ups.com/api/reference/rating/appendix?loc=en_US

@danh91 please advise me where I should add them, thank you in advance

@jacobshilitz
Copy link
Collaborator Author

see #673, I'm sure you will have many comments, I first did a quick PR, but its not ready of course

@danh91 danh91 linked a pull request Sep 11, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant