-
Notifications
You must be signed in to change notification settings - Fork 890
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added unit tests for resourceinterpreter webhook configmanager #5832
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5832 +/- ##
==========================================
+ Coverage 46.04% 46.19% +0.14%
==========================================
Files 659 660 +1
Lines 53957 53985 +28
==========================================
+ Hits 24847 24938 +91
+ Misses 27494 27427 -67
- Partials 1616 1620 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Signed-off-by: Anuj Agrawal <[email protected]>
448e41d
to
352446e
Compare
/retest |
@anujagrawal699: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Hi @XiShanYongYe-Chang , can u trigger a retest? |
Yes~ |
/assign |
Description:
This PR adds comprehensive unit tests for the resourceinterpreter webhook configmanager. These tests verify the core functionality of webhook configuration handling and access, including configuration syncing, merging, and accessor behaviors.
Additions:
Test Coverage:
What type of PR is this?
/kind feature
Which issue(s) this PR fixes:
Fixes a part of #5470
Does this PR introduce a user-facing change?: