Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added unit tests for resourceinterpreter webhook configmanager #5832

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

anujagrawal699
Copy link
Contributor

Description:
This PR adds comprehensive unit tests for the resourceinterpreter webhook configmanager. These tests verify the core functionality of webhook configuration handling and access, including configuration syncing, merging, and accessor behaviors.

Additions:

  1. pkg/resourceinterpreter/customized/webhook/configmanager/manager_test.go
  2. pkg/resourceinterpreter/customized/webhook/configmanager/accessor_test.go

Test Coverage:

  1. pkg/resourceinterpreter/customized/webhook/configmanager/manager_test.go : 0% to 81%
  2. pkg/resourceinterpreter/customized/webhook/configmanager/accessor_test.go : 0% to 86.4%

What type of PR is this?
/kind feature

Which issue(s) this PR fixes:
Fixes a part of #5470

Does this PR introduce a user-facing change?:

NONE

@karmada-bot karmada-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 18, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign xishanyongye-chang for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 18, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 18, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.19%. Comparing base (ae65de4) to head (352446e).
Report is 4 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5832      +/-   ##
==========================================
+ Coverage   46.04%   46.19%   +0.14%     
==========================================
  Files         659      660       +1     
  Lines       53957    53985      +28     
==========================================
+ Hits        24847    24938      +91     
+ Misses      27494    27427      -67     
- Partials     1616     1620       +4     
Flag Coverage Δ
unittests 46.19% <ø> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@RainbowMango
Copy link
Member

The #5834 will fix the failing tests. Please rebase this PR after #5834.
Sorry for the inconvenience.

@anujagrawal699 anujagrawal699 force-pushed the addedTests-pkg/resourceinterpreter/customized/webhook/configmanager branch from 448e41d to 352446e Compare November 19, 2024 06:35
@anujagrawal699
Copy link
Contributor Author

The #5834 will fix the failing tests. Please rebase this PR after #5834. Sorry for the inconvenience.

Okay, Thanks!

@anujagrawal699
Copy link
Contributor Author

/retest

@karmada-bot
Copy link
Collaborator

@anujagrawal699: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@anujagrawal699
Copy link
Contributor Author

@anujagrawal699: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Hi @XiShanYongYe-Chang , can u trigger a retest?

@XiShanYongYe-Chang
Copy link
Member

Yes~
/retest

@zhzhuang-zju
Copy link
Contributor

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants