/help

Looking forward to interested people to participate in this work. Feel free to communicate if you have any questions.

@XiShanYongYe-Chang:
This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

I would be interested in contributing :)

/assign

Thanks a lot ^-^ @a7i

Two areas I could use some guidance on:

1. Migration of existing Work that is suspended via annotation. How do you think this should be done?

2. Querying Work by label Selector. It seems to me that we should leave the label for work created by MultiClusterService. Thoughts?
   

   karmada/pkg/controllers/multiclusterservice/mcs_controller.go

   Lines 133 to 135 in 004de43

   	workList, err := helper.GetWorksByLabelsSet(ctx, c, labels.Set{
   	networkingv1alpha1.MultiClusterServicePermanentIDLabel: mcsID,
   	})

Hi @a7i

For 1: Existing works that use the propagation.karmada.io/instruction label are collected from member clusters and are used to wrap the EndpointSlice objects; they do not have corresponding resource templates in the Karmada control plane. Therefore, I understand that they will not introduce upgrade issues and can be processed directly.

For 2, I‘m sorry, I didn't quite understand the meaning of the question.

Hi @XiShanYongYe-Chang I meant to reference this line of code:

As you can see above, it performs a List using label-selector. Do you propose leaving that label for a more efficient query?

Hi @a7i, Good question. From the list work here, keeping the label is really helpful for efficient query. Unless a new label replaces the current label, let's pause the task and wait for a more complete plan before starting it. How do you think?

From the list work here, keeping the label is really helpful for efficient query.

Why not directly use field selector? I don‘t know whether label query is way more efficient than field query.

Why not directly use field selector?

Which field is used for filtering?

Which field is used for filtering?

I mean spec.suspendDispatching, does it achieve original purpose?

Thanks @vie-serendipity, maybe it's possible.

After thinking about it, we can follow the following steps:

1. Set the suspendDispatching field for the collected work.
2. Replace the logic of the labelselector.
3. Deprecated the propagation.karmada.io/instruction label.

How do you think?

I think it could work.

Would you like to do it?

Sure, I will submit a PR after I implement it.

Thanks a lot @vie-serendipity~
/assign @vie-serendipity

Hi @a7i, @vie-serendipity would like to move forward with this task using the filed selector. How do you think?

Hi @vie-serendipity I want to know if you have a plan of action for the next step, not to rush, just to know.

I am currently developing and expect to submit a PR before the Spring Festival.

That's a good idea, thanks @vie-serendipity !