remove data binding with view binding, support java 17

Author: kanchan.pal

app/build.gradle

@@ -1,12 +1,11 @@
 plugins {
-    id ("com.android.application")
+    id("com.android.application")
     id("jacoco")
     id("kotlin-android")
     id("kotlin-kapt")
     id("kotlin-allopen")
     id("androidx.navigation.safeargs.kotlin")
     id("com.google.dagger.hilt.android")
-
 }
 
 allOpen {
@@ -15,21 +14,24 @@ allOpen {
 }
 
 android {
-    compileSdkVersion 33
+    namespace "com.kanchanpal.newsfeed"
+    compileSdk 34
 
     buildFeatures {
 
-        dataBinding true
         viewBinding = true
+        buildConfig = true
+    }
 
-        // for view binding:
-        // viewBinding true
+    compileOptions {
+        sourceCompatibility JavaVersion.VERSION_17
+        targetCompatibility JavaVersion.VERSION_17
     }
 
     defaultConfig {
         applicationId "com.kanchanpal.newsfeed"
         minSdkVersion 21
-        targetSdkVersion 33
+        targetSdkVersion 34
         versionCode 1
         versionName "1.0"
         testInstrumentationRunner "com.kanchanpal.newsfeed.util.AppTestRunner"
@@ -57,6 +59,10 @@ android {
     }
 }
 
+kotlin {
+    jvmToolchain (17)
+}
+
 jacoco {
     toolVersion = "$rootProject.jacocoVersion"
 }
@@ -68,8 +74,8 @@ dependencies {
     implementation 'androidx.constraintlayout:constraintlayout:1.1.3'
     testImplementation 'junit:junit:4.12'
 
-    implementation("com.google.dagger:hilt-android:2.44")
-    kapt("com.google.dagger:hilt-android-compiler:2.44")
+    implementation("com.google.dagger:hilt-android:2.47")
+    kapt("com.google.dagger:hilt-android-compiler:2.47")
 
     kapt "androidx.room:room-compiler:$rootProject.roomVersion"
     kapt "com.github.bumptech.glide:compiler:$rootProject.glideVersion"
@@ -132,8 +138,8 @@ dependencies {
     androidTestImplementation "org.mockito:mockito-core:$rootProject.mockitoVersion"
     androidTestImplementation "org.mockito:mockito-android:$rootProject.mockitoAndroidVersion"
 
-    androidTestImplementation ('androidx.test.espresso:espresso-core:' + rootProject.espressoVersion) {
-        exclude group:'com.androidx.support'
+    androidTestImplementation('androidx.test.espresso:espresso-core:' + rootProject.espressoVersion) {
+        exclude group: 'com.androidx.support'
 
     }
 }
@@ -145,8 +151,8 @@ task fullCoverageReport(type: JacocoReport) {
     dependsOn 'createDebugCoverageReport'
     dependsOn 'testDebugUnitTest'
     reports {
-        xml.enabled = true
-        html.enabled = true
+        xml.getRequired().set(true)
+        html.getRequired().set(true)
     }
 
     def fileFilter = ['**/R.class', '**/R$*.class', '**/BuildConfig.*', '**/Manifest*.*',
@@ -157,19 +163,19 @@ task fullCoverageReport(type: JacocoReport) {
                       '**/*_*Factory.class',
                       '**/*ComponentImpl.class',
                       '**/*SubComponentBuilder.class']
-    def debugTree = fileTree(dir: "${buildDir}/intermediates/classes/debug", excludes: fileFilter)
+    def debugTree = fileTree(dir: "${layout.buildDir}/intermediates/classes/debug", excludes: fileFilter)
     def mainSrc = "${project.projectDir}/src/main/java"
 
     sourceDirectories.from = files([mainSrc])
     classDirectories.from = files([debugTree])
-    executionData.from = fileTree(dir: "$buildDir", includes: [
+    executionData.from = fileTree(dir: "${layout.buildDirectory}", includes: [
             "jacoco/testDebugUnitTest.exec",
             "outputs/code-coverage/connected/*coverage.ec"
     ])
 }
 
 // we need all open to run tests which  a we enable only for debug builds.
-project.tasks.whenTaskAdded {
+project.tasks.configureEach {
     if (it.name == "testReleaseUnitTest") {
         it.enabled = false
     }

app/src/main/java/com/kanchanpal/newsfeed/MainActivity.kt

@@ -2,7 +2,6 @@ package com.kanchanpal.newsfeed
 
 import android.os.Bundle
 import androidx.appcompat.app.AppCompatActivity
-import androidx.databinding.DataBindingUtil
 import androidx.navigation.NavController
 import androidx.navigation.findNavController
 import com.kanchanpal.newsfeed.databinding.ActivityMainBinding
@@ -11,12 +10,12 @@ import dagger.hilt.android.AndroidEntryPoint
 @AndroidEntryPoint
 class MainActivity : AppCompatActivity() {
     private lateinit var navController: NavController
+    private lateinit var binding: ActivityMainBinding
 
     override fun onCreate(savedInstanceState: Bundle?) {
         super.onCreate(savedInstanceState)
-
-        val binding : ActivityMainBinding = DataBindingUtil.setContentView(this,R.layout.activity_main)
-
+        binding = ActivityMainBinding.inflate(layoutInflater)
+        setContentView(binding.root)
         navController = findNavController(R.id.nav_fragment)
     }
 }

app/src/main/java/com/kanchanpal/newsfeed/api/ResponseModel.kt

@@ -2,12 +2,15 @@ package com.kanchanpal.newsfeed.api
 
 import androidx.room.Embedded
 import androidx.room.Entity
+import androidx.room.Ignore
 import androidx.room.PrimaryKey
 import com.google.gson.annotations.Expose
 import com.google.gson.annotations.SerializedName
 import java.io.Serializable
+import java.util.UUID
 
 
+@Entity
 data class NewsListResponse(
     @Expose
     @SerializedName("source")
@@ -21,11 +24,10 @@ data class NewsListResponse(
 
 @Entity
 data class NewsListModel  (
-
     @PrimaryKey
     @Expose
     @SerializedName("title")
-    var title: String = "",
+    var title: String = UUID. randomUUID().toString(),
     @Expose
     @SerializedName("urlToImage")
     var urlToImage: String? = null,
@@ -41,8 +43,8 @@ data class NewsListModel  (
     @Expose
     @SerializedName("publishedAt")
     var publishedAt: String? = null,
-
-    @Embedded @SerializedName("source") val source : Source? = null ) : Serializable
+    @Embedded
+    @SerializedName("source") var source : Source? = null ) : Serializable
 
 data class Source(
     @SerializedName("id")

app/src/main/java/com/kanchanpal/newsfeed/common/BindingAdapters.kt

@@ -9,16 +9,13 @@ import androidx.room.Query
 import com.kanchanpal.newsfeed.api.NewsListModel
 
 @Dao
-interface NewsDao {
+interface  NewsDao {
     @Query("Select * from NewsListModel")
-    fun getNews() : LiveData<List<NewsListModel>>
+     fun getNews() : LiveData<List<NewsListModel>>
 
     @Insert(onConflict = OnConflictStrategy.REPLACE)
-     suspend fun insertAll(newsList: List<NewsListModel>)
-
-    @Insert(onConflict = OnConflictStrategy.REPLACE)
-    suspend fun insert(news: NewsListModel)
+    fun insert(news: NewsListModel)
 
     @Query("SELECT * FROM NewsListModel")
-    fun getPagedNews(): DataSource.Factory<Int, NewsListModel>
+     fun getPagedNews(): DataSource.Factory<Int, NewsListModel>
 }

app/src/main/java/com/kanchanpal/newsfeed/data/dao/NewsDao.kt

@@ -55,7 +55,9 @@ class NewsPageDataSource @Inject constructor(
                 }
                 is Result.Success -> {
                     val results = response.data.articles
-                    newsDao.insertAll(results)
+                    for (result in results) {
+                        newsDao.insert(result)
+                    }
                     callback(results)
                     networkState.postValue(NetworkState.LOADED)
                 }

app/src/main/java/com/kanchanpal/newsfeed/data/newsSet/NewsPageDataSource.kt

@@ -7,6 +7,7 @@ import androidx.navigation.findNavController
 import androidx.paging.PagedListAdapter
 import androidx.recyclerview.widget.DiffUtil
 import androidx.recyclerview.widget.RecyclerView
+import com.bumptech.glide.Glide
 import com.kanchanpal.newsfeed.api.NewsListModel
 import com.kanchanpal.newsfeed.databinding.RvNewsListItemsBinding
 
@@ -18,18 +19,24 @@ class NewsAdapter : PagedListAdapter<NewsListModel, NewsAdapter.ViewHolder>(Diff
     override fun onBindViewHolder(holder: ViewHolder, position: Int) {
         val newsItem = getItem(position)
         holder.apply {
-            bind(createOnClickListener( newsItem), newsItem)
+            bind(createOnClickListener(newsItem), newsItem)
             itemView.tag = newsItem
         }
     }
+
     override fun onCreateViewHolder(parent: ViewGroup, viewType: Int): ViewHolder {
-        return ViewHolder(RvNewsListItemsBinding.inflate(
-                LayoutInflater.from(parent.context), parent, false))
+        return ViewHolder(
+            RvNewsListItemsBinding.inflate(
+                LayoutInflater.from(parent.context), parent, false
+            )
+        )
     }
-    private fun createOnClickListener( newItem: NewsListModel?): View.OnClickListener {
+
+    private fun createOnClickListener(newItem: NewsListModel?): View.OnClickListener {
         return View.OnClickListener {
-          val direction = NewsListFragmentDirections
-              .actionNewsListFragmentToNewsDetailFragment(newItem ?: NewsListModel())
+            val direction = NewsListFragmentDirections.actionNewsListFragmentToNewsDetailFragment(
+                newItem ?: NewsListModel()
+            )
             it.findNavController().navigate(direction)
         }
     }
@@ -40,9 +47,12 @@ class NewsAdapter : PagedListAdapter<NewsListModel, NewsAdapter.ViewHolder>(Diff
 
         fun bind(listener: View.OnClickListener, item: NewsListModel?) {
             binding.apply {
-                clickListener = listener
-                newsItem = item
-                executePendingBindings() }
+                clNews.setOnClickListener(listener)
+                textView.text = item?.title
+               // tvChannel.text = item?.source?.name
+                tvDate.text = item?.publishedAt?.substring(0, 10)
+                Glide.with(itemView).load(item?.urlToImage).into(binding.ivNews)
+            }
         }
     }
 }

app/src/main/java/com/kanchanpal/newsfeed/news/NewsAdapter.kt

@@ -6,6 +6,8 @@ import android.view.View
 import android.view.ViewGroup
 import androidx.fragment.app.Fragment
 import androidx.navigation.fragment.navArgs
+import com.bumptech.glide.Glide
+import com.kanchanpal.newsfeed.api.NewsListModel
 import com.kanchanpal.newsfeed.databinding.FragmentNewsDetailBinding
 
 class NewsDetailFragment : Fragment() {
@@ -22,7 +24,17 @@ class NewsDetailFragment : Fragment() {
             activity?.supportFragmentManager?.popBackStack()
         }
         val newsModel = args.newsItem
-        binding.newsDetail = newsModel
+        populateDetailsFields(newsModel, binding)
         return binding.root
     }
+
+    private fun populateDetailsFields(newsModel: NewsListModel, binding: FragmentNewsDetailBinding) {
+        binding.apply {
+           // tvSource.text = newsModel.source?.name
+            tvDate.text = newsModel.publishedAt
+            tvDescDetail.text = newsModel.description
+            tvHeadLineDetail.text = newsModel.title
+            Glide.with(requireActivity()).load(newsModel.urlToImage).into(imageView)
+        }
+    }
 }

app/src/main/java/com/kanchanpal/newsfeed/news/NewsDetailFragment.kt

@@ -1,9 +1,8 @@
 <?xml version="1.0" encoding="utf-8"?>
-<layout xmlns:android="http://schemas.android.com/apk/res/android"
-    xmlns:app="http://schemas.android.com/apk/res-auto">
-    <LinearLayout
-        android:layout_width="match_parent"
+<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
+    xmlns:app="http://schemas.android.com/apk/res-auto"
         android:layout_height="match_parent"
+        android:layout_width="match_parent"
         android:orientation="vertical">
 
         <fragment
@@ -14,5 +13,4 @@
             app:defaultNavHost="true"
             app:navGraph="@navigation/nav_main"/>
 
-    </LinearLayout>
-</layout>
+</LinearLayout>