Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

commands with --federation not working. #2683

Open
4 tasks
anandwali opened this issue Jan 10, 2024 · 3 comments
Open
4 tasks

commands with --federation not working. #2683

anandwali opened this issue Jan 10, 2024 · 3 comments

Comments

@anandwali
Copy link

Issue workflow progress

Progress of the issue based on the
Contributor Workflow

  • 1. The issue provides a reproduction available on GitHub, Stackblitz or CodeSandbox

    Make sure to fork this template and run pnpm generate in the terminal.

    Please make sure the Codegen and plugins version under package.json matches yours.

  • 2. A failing test has been provided
  • 3. A local solution has been provided
  • 4. A pull request is pending review

Describe the bug

graphql-inspector diff not working for schemas with federated directives like @link, @key, @Shareable.

I tried supplying --federation tag to the command, still it does not work. Any other way to make it work is helpful..

To Reproduce Steps to reproduce the behavior:

Expected behavior

Environment:

  • OS:
  • @graphql-inspector/...:
  • graphql:
  • NodeJS:

Additional context

@TuvalSimha
Copy link
Collaborator

Hi @anandwali,
I appreciate you bringing up this new issue :)

Could you kindly provide more details? I attempted to reproduce it, but everything seemed to be working perfectly fine.

@cgriego
Copy link

cgriego commented Apr 17, 2024

I think the issue is Apollo Federation support was added back in 2020 for v1 of Federation and hasn't been updated since for v2.0 or newer

@oskargotte
Copy link

It seems you are right @cgriego. The code to handle federated schemas only considers v1 directives.
More directives needs to be included to support v2 and especially the @link directive which is present in all federated schemas using v2 or newer, see apollo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants