Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(release): build arm64 containers #2678

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bardiharborow
Copy link

Description

This modifies the Docker build pipeline to build Arm64 images in addition to the existing Amd64 images.

Fixes #2677

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

...

Checklist:

  • I have followed the
    CONTRIBUTING doc and the
    style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link

changeset-bot bot commented Dec 16, 2023

⚠️ No Changeset found

Latest commit: c414247

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@TuvalSimha
Copy link
Collaborator

Hi @bardiharborow,
Thank you for this PR, can you make the CI check pass please?

@bardiharborow
Copy link
Author

@TuvalSimha I have corrected the linting error, however the CI pipeline appears to have been broken for other reasons since February, which may impact being able to move forward with this change. Do you have any idea how you would like to resolve that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Arm64 container builds
2 participants