Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to monorepo #369

Open
wants to merge 31 commits into
base: main
Choose a base branch
from
Open

Migrate to monorepo #369

wants to merge 31 commits into from

Conversation

kamiazya
Copy link
Owner

This pull request includes the migration to a monorepo structure, updates dependencies, fixes tests, and makes various code improvements. It also moves the Rust project to the packages/wasm directory and updates the fast-check dependency. Additionally, it updates the typedoc configuration, .gitignore file, biome configuration, and biome version. Finally, it separates packages and updates the tsconfig.json files.

Copy link

changeset-bot bot commented Sep 14, 2024

🦋 Changeset detected

Latest commit: 5415137

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
web-csv-toolbox Minor
@web-csv-toolbox/common Minor
@web-csv-toolbox/parser Minor
@web-csv-toolbox/shared Minor
@web-csv-toolbox/wasm Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

coderabbitai bot commented Sep 14, 2024

Important

Review skipped

More than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review.

66 files out of 160 files are above the max files limit of 75. Please upgrade to Pro plan to get higher limits.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    -- I pushed a fix in commit <commit_id>, please review it.
    -- Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    -- @coderabbitai generate unit testing code for this file.
    -- @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    -- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    -- @coderabbitai read src/utils.ts and generate unit testing code.
    -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

codecov bot commented Sep 14, 2024

Bundle Report

Changes will decrease total bundle size by 313.34kB (-54.59%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
@web-csv-toolbox/shared-esm 3.1kB 3.1kB ⬆️
@web-csv-toolbox/common-esm 2.89kB 2.89kB ⬆️
@web-csv-toolbox/wasm-esm 237.21kB 237.21kB ⬆️
@web-csv-toolbox/parser-esm 17.27kB 17.27kB ⬆️
web-csv-toolbox-esm 173 bytes 173 bytes ⬆️
web-csv-toolbox-CSV-esm (removed) 230.45kB ⬇️
web-csv-toolbox-CSV-esm-CSV-cjs (removed) 219.71kB ⬇️
web-csv-toolbox-CSV-umd (removed) 123.83kB ⬇️

Copy link

codecov bot commented Sep 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (ae0d4f2) to head (5415137).

Additional details and impacted files
@@             Coverage Diff             @@
##             main      #369      +/-   ##
===========================================
+ Coverage   99.51%   100.00%   +0.48%     
===========================================
  Files          38        36       -2     
  Lines         416       422       +6     
  Branches       97        99       +2     
===========================================
+ Hits          414       422       +8     
+ Misses          2         0       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Sep 14, 2024

CodSpeed Performance Report

Merging #369 will create unknown performance changes

Comparing monorepo (5415137) with main (ae0d4f2)

Summary

🆕 40 new benchmarks
⁉️ 7 (👁 7) dropped benchmarks

Benchmarks breakdown

Benchmark main monorepo Change
👁 parseBinary.toArraySync(50 rows) 565.4 µs N/A N/A
👁 parseBinary.toIterableIterator(50 rows) 558.9 µs N/A N/A
👁 parseBinary.toStream(50 rows) 1.8 ms N/A N/A
👁 parseString.toArraySync(50 rows) 548.9 µs N/A N/A
👁 parseString.toIterableIterator(50 rows) 620.8 µs N/A N/A
👁 parseString.toStream(50 rows) 1.8 ms N/A N/A
👁 parseStringToArraySyncWASM(50 rows) 578.6 µs N/A N/A
🆕 parse a binary 100 row CSV into a IterableIterator N/A 2.3 ms N/A
🆕 parse a binary 100 row CSV into a Promise<Array> N/A 2.4 ms N/A
🆕 parse a binary 100 row CSV into a ReadableStream N/A 4.7 ms N/A
🆕 parse a binary 100 row CSV into an Array N/A 2.3 ms N/A
🆕 parse a binary 100 row CSV into an AsyncIterableIterator N/A 2.4 ms N/A
🆕 parse a binary 1000 row CSV into a IterableIterator N/A 115.6 ms N/A
🆕 parse a binary 1000 row CSV into a Promise<Array> N/A 281.8 ms N/A
🆕 parse a binary 1000 row CSV into a ReadableStream N/A 241.1 ms N/A
🆕 parse a binary 1000 row CSV into an Array N/A 203.8 ms N/A
🆕 parse a binary 1000 row CSV into an AsyncIterableIterator N/A 115.6 ms N/A
🆕 parse a binary 50 row CSV into a IterableIterator N/A 1.4 ms N/A
🆕 parse a binary 50 row CSV into a Promise<Array> N/A 2.1 ms N/A
🆕 parse a binary 50 row CSV into a ReadableStream N/A 2.5 ms N/A
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

@kamiazya kamiazya self-assigned this Sep 15, 2024
@kamiazya kamiazya added the enhancement New feature or request label Sep 15, 2024
@kamiazya kamiazya marked this pull request as ready for review September 15, 2024 07:43
@kamiazya
Copy link
Owner Author

@coderabbitai review

Copy link
Contributor

coderabbitai bot commented Sep 15, 2024

Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant