Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Typecheck on CI #331

Open
kamiazya opened this issue Aug 18, 2024 · 0 comments
Open

Enable Typecheck on CI #331

kamiazya opened this issue Aug 18, 2024 · 0 comments
Labels
enhancement New feature or request github_actions Pull requests that update GitHub Actions code

Comments

@kamiazya
Copy link
Owner

Problem Details

In Vitest version 1.x, running the following command for typecheck tests causes the process to hang, preventing the tests from completing successfully:

vitest --typecheck

As a result, typecheck tests are currently skipped in the CI environment.

Local Confirmation

Testing with Vitest version 2.x and above locally confirms that the typecheck tests run successfully without hanging.

Proposed Solution

I propose adding a test:type job to the scripts section of the package.json, which will run typecheck tests using Vitest 2.x and above in the CI environment.

"scripts": {
  "test:type": "vitest --typecheck.only"
}

This will ensure that typecheck tests are automatically run in the CI environment, helping to maintain type safety.

@kamiazya kamiazya added enhancement New feature or request github_actions Pull requests that update GitHub Actions code labels Aug 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

No branches or pull requests

1 participant