Skip to content

Latest commit

 

History

History
327 lines (190 loc) · 12 KB

contributing.md

File metadata and controls

327 lines (190 loc) · 12 KB
Raw

Jump to:

For all development

BizHawk's source is hosted with Git.

  • Linux
    • If it's not already installed, the package name is probably git.
  • macOS
    • Git comes with Xcode, or it can be installed manually or with Homebrew (full instructions).
  • Windows
    • Your IDE probably has Git support, or you could install the Git CLI, or a GUI such as GitHub Desktop or GitKraken.
    • You can also use Git from within WSL2.

To download the repo, first make sure you have a fork on GitHub (check the dropdown beside the "Fork" button at the top of the page). Then clone your fork with Git. You should add the main repo as an extra remote (upstream) to stay up-to-date. With the CLI that would look like:

git remote add upstream https://github.com/TASEmulators/BizHawk.git
git fetch upstream
git branch --set-upstream-to=upstream/master master

Before touching the code, create a new branch off master with a descriptive name.

After touching the code, commit your changes. Try to group your changes into many smaller commits with a clear purpose to each—committing early and often can help. Bonus points if each commit can build and run.
If you made the branch a while ago, pull master and rebase, not merge. Then push to your fork, and you can submit a pull request at any time on GitHub.
Your commit message summary should be written in the imperative tense (imagine "This commit will ..." comes before it). GitHub wraps at 70 chars.
The description should include any non-obvious effects the changes will have. If you feel you need to explain what the code does, consider using code comments instead. It's okay to leave the description blank for simple commits.
You can use limited Markdown in the summary and description, including monospace, commit/Issue links, and, in the description, bullet points. In the description, link to related commits and Issues with a short-hash (abc123def) or ID (#1234), respectively. If your commit fixes an Issue, put it in the summary and use a closing keyword.

It's probably a good idea to get the .NET SDK, even if you're not working on a .NET project, so that you can test your changes in EmuHawk.

For any: .NET project

  • Linux
    • Install the .NET 8 SDK (package name is usually dotnet-sdk-8.0, see full instructions).
    • VS Community isn't available for Linux, but Rider and VS Code are.
    • Nix/NixOS users can get the .NET SDK ephemerally with the provided shell.nix. For IDE setup and more, see the Nix-specific docs.
  • macOS
    • Note that EmuHawk does not currently support macOS.
    • Install the .NET 8 SDK manually or with Homebrew.
    • VS Community isn't available for macOS, but Rider and VS Code are, and for now so is VS for Mac.
  • Windows

For EmuHawk and libraries in the main solution, which do not target .NET 8, we have this page documenting which features are actually available to use.

blip_buf

Audio resampling library.

Uses C.

Encore

Build scripts for the (unmanaged side of the) Encore port.

Uses C++.

Cygne

The unmanaged side of the Cygne core from Mednafen.

Uses C++.

DiscoHawk

DiscoHawk is a companion app for cleaning up disc images.

See EmuHawk. Build scripts also build DiscoHawk, or from VS2022 choose a DiscoHawk configuration.

EmuHawk

EmuHawk is the main app, an emulator frontend.

Uses C#; you will need the .NET SDK or an IDE which includes it. See the .NET section. Most projects target .NET Standard 2.0, with some targeting .NET Framework 4.8. It's written at the top of their project files, or you can check the project graph.

The source for EmuHawk, plus DiscoHawk and the supporting libraries, is in /src, with a few extra files used by the build system elsewhere. EmuHawk's project file /src/BizHawk.Client.EmuHawk/BizHawk.Client.EmuHawk.csproj includes the other projects in a tree, and they're all included in /BizHawk.sln.

In VS2022, open BizHawk.sln, then select the "BizHawk.Client.EmuHawk | Release" configuration to build and run. To build from the command-line on Windows, simply run dotnet build BizHawk.sln from the repository's root, and then output\EmuHawk will be available. Alternatively, you can run one of the existing build scripts that apply additional checks and configurations, such as Dist\QuickTestBuildAndPackage_Release.bat. To build from the command-line on Unix, run Dist/BuildRelease.sh, and then output/EmuHawkMono.sh will be available.

There are 2 build configurations. Besides Release there is Debug, which does not run bytecode optimisations, does not remove debugging symbols, enables additional logging and assertions, and enables some features. On Windows, a Debug executable will spawn a console window for stdout. Note there is also a "stronger" release build in the form of VersionInfo.DeveloperBuild == false, which is only used by GitLab CI for preparing a release (during Dist/UpdateVersionInfoForRelease.sh).

We have an automated test suite in the solution which runs in CI, though you can and should run it before pushing. There are also various Analyzers (static code analysis plugins) for detecting common mistakes and checking code style. These are disabled by default for the main solution; pass -p:RunAnalyzersDuringBuild=true to the build script, or set the env. var MachineRunAnalyzersDuringBuild=1. In addition, not every style rule is currently enabled, so please make sure you use CRLF, tabs, and Allman braces (but don't try to fix code you're not working on).

There are additional test suites specifically for regression-testing cores—these are not included in the solution and need to be run manually. See the base project's readme for details.

Ext. tools

Various tools/plugins to be loaded in EmuHawk.

These use C#; you will need the .NET SDK or an IDE which includes it. See the .NET section.

AutoGenConfig

Experiment in generating settings UI from reflection metadata. (To get something nicer-looking than PropertyGrid.)

DATParser

Automates gamedb intake.

DBMan

Various disc image and gamedb utilities.

HelloWorld

Just example code. Not really idiomatic for ext. tools but oh well.

Handy

The unmanaged side of the Handy core from Mednafen.

Uses C++.

HawkQuantizer

Library used to encode .gif videos.

Uses C#; you will need the .NET SDK or an IDE which includes it. See the .NET section.

iso-parser

Library used for disc image parsing.

Uses C#; you will need the .NET SDK or an IDE which includes it. See the .NET section.

LibBizAbiAdapter

A tiny shim used by BizHawk.BizInvoke.

Uses x86 assembly.

LibBizHash

Used for hardware-accelerated computation of checksums, since proper ISA extension support isn't available until .NET 6.

Uses C.

libmupen64plus

The unmanaged side of the Mupen64Plus core and its bundled plugins.

These use C/C++.

librcheevos

Build scripts for the rcheevos library, used for RetroAchievements support in EmuHawk.

Uses C.

LibretroBridge

The unmanaged side of EmuHawk's Libretro adapter.

Uses C++.

Mednadisc

Library for reading disc images, ported from Mednafen.

Uses C++.

Misc. submodules

Emu83

The unmanaged side of the Emu83 core.

Gambatte-Speedrun

The unmanaged side of the Gambatte core.

libdarm

Library for ARM disassembly, used for mGBA core.

libfwunpack

Library for manipulating NDS firmware data.

mGBA

The unmanaged side of the mGBA core.

SameBoy

The unmanaged side of the SameBoy core.

MSXHawk

The unmanaged side of the MSXHawk core.

Uses C++.

NLua

Part of EmuHawk's Lua host.

Uses C#; you will need the .NET SDK or an IDE which includes it. See the .NET section.

Nyma cores

Several cores ported from Mednafen with minimal changes, so tracking upstream is easier.

See Waterbox (toolchain + cores).

Octoshock

The unmanaged side of the Octoshock core from Mednafen.

Uses C++.

quickerNES

The unmanaged side of the quickerNES core.

Uses C++.

Roslyn Analyzers

Plugins for the C# compiler, used in main BizHawk solution projects.

These use C#; you will need the .NET SDK or an IDE which includes it. See the .NET section.

BizHawk Analyzer

Performs additional code style checks not covered by the other Analyzers.

ReflectionCache Source Generator

Generates a helper class in an assembly for accessing <EmbeddedResource/>s and Types.

SettingsUtil Source Generator

Extra codegen for settings and sync settings object serialisation.

VersionInfo Source Generator

Adds metadata from Git to BizHawk.Common.

Virtu

Library containing most of the Virtu core's emulation code.

Uses C#; you will need the .NET SDK or an IDE which includes it. See the .NET section.

Waterbox (host)

Memory management and other wizardry for loading Waterboxed cores.

Uses Rust.

See waterboxhost readme.

Waterbox (toolchain + cores)

Sandboxing wizardry.

Uses C/C++ targeting Linux w/ a custom libc based on musl.

See Waterbox readme.

Copyrights and licensing

By contributing, you declare that any additions or changes either:

  • were authored by you and you are willing to license your contributions to us under the project's license; or
  • were copied from a compatibly open-source, publicly-licensed source and are properly attributed, including licensing info.

Important

We will not accept any contributions "authored" by GitHub Copilot or similar ML tools.