Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add subtract method "sub" in the class "Calculator" #6

Open
kdh0429 opened this issue Dec 29, 2018 · 8 comments
Open

Add subtract method "sub" in the class "Calculator" #6

kdh0429 opened this issue Dec 29, 2018 · 8 comments
Assignees
@kdh0429 @penpaperkeycode

Comments

@kdh0429
Copy link
Collaborator

kdh0429 commented Dec 29, 2018 •
edited
Loading

  1. implement an sub method
    the method receives two float inputs and output is subtraction result of first input to second input as float

  2. implement a test for sub method
    test will be done on the implemented script

Example)

calc=Calculator()
#two float inputs
a=2.0
b=2.0

assert calc.sub(a,b) == 0.0

>>> Passed
@penpaperkeycode penpaperkeycode changed the title Subtract function Make subtract function to class calculator Dec 29, 2018
@penpaperkeycode penpaperkeycode changed the title Make subtract function to class calculator Make subtract function Dec 29, 2018
@Curt-Park
Copy link
Contributor

  1. Please modify the subject following the git commit message convention.
  2. Please add any test case example for better understanding of the feature.

@kdh0429 kdh0429 changed the title Make subtract function Add subtract function "subs" in calculator Dec 29, 2018
@kdh0429 kdh0429 changed the title Add subtract function "subs" in calculator Add subtract function "sub" in calculator Dec 29, 2018
@kdh0429 kdh0429 changed the title Add subtract function "sub" in calculator Add subtract method "sub" in the class "Calculator" Dec 29, 2018
@penpaperkeycode
Copy link
Collaborator

Master, please check our updates.

@Curt-Park
Copy link
Contributor

Looks good. but you don't need to add 'print' line.

@kdh0429
Copy link
Collaborator Author

kdh0429 commented Dec 29, 2018

We've deleted 'print' line.

@Curt-Park
Copy link
Contributor

Good. I will make a feature branch for you now.

@Curt-Park
Copy link
Contributor

@kdh0429 @IntelligenceDatum Please add the issue card in the project board (in progress setting)

@Curt-Park
Copy link
Contributor

@kdh0429 @IntelligenceDatum I made a branch for you: feat/calculator/sub
Good luck.

@penpaperkeycode
Copy link
Collaborator

Please check our added issue card in the project board

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kdh0429 kdh0429

@penpaperkeycode penpaperkeycode

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Curt-Park @kdh0429 @penpaperkeycode