Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature References Request #82

Closed
smhmayboudi opened this issue Nov 15, 2020 · 3 comments
Closed

Feature References Request #82

smhmayboudi opened this issue Nov 15, 2020 · 3 comments

Comments

@smhmayboudi
Copy link

Do you have any plan to support references?

Example:

{
  "references": [
    {
      "name": "RtValidateReqDto",
      "subject": "fip.common.RtValidateReqDto",
      "version": 1
    },
    {
      "name": "RtResDto",
      "subject": "fip.common.RtResDto",
      "version": 1
    }
  ],
  "schema":"{\"namespace\":\"fip.common\",\"name\":\"RtValidateDto\",\"type\":\"record\",\"fields\":[{\"name\":\"err\",\"type\":[\"null\",\"string\"],\"default\":null},{\"name\":\"req\",\"type\":[\"null\",\"RtValidateReqDto\"],\"default\":null},{\"name\":\"res\",\"type\":[\"null\",\"RtResDto\"],\"default\":null}]}",
  "schemaType":"AVRO"
}
@slominskir
Copy link

Another attempt at references: #121

Can we get one of these merged?

@brinchj
Copy link

brinchj commented Jul 30, 2021

Hi Folks. I would love for this project to support Protocol Buffer references (imports). I have written up a PR that implements the first step of this support over in #135

I have just updated the description to explain the context, how it works, and what's still missing (as far as I know). I would greatly appreciate if one of you would take a look and tell me if it makes sense, or if there are parts that are not easy to follow 👍

@brinchj
Copy link

brinchj commented Jul 30, 2021

Perhaps we can team up and create a little task force for all of us who are interested in adding support for references :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants