Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This library is still maintained? #215

Closed
zion03 opened this issue Sep 28, 2022 · 4 comments
Closed

This library is still maintained? #215

zion03 opened this issue Sep 28, 2022 · 4 comments

Comments

@zion03
Copy link

zion03 commented Sep 28, 2022

Hello there!

First, thanks for all of your work and this library.

Just one question:
Who can confirm that this library is still maintained?
Would be nice to hear a responsible person for this repo or at least a person who has access to merge PR.

Reason:
Many useful changes are available in PRs.
For example, one of them #197 is approved and ready to merge.

@hilleer
Copy link

hilleer commented Sep 29, 2022

@zion03 FYI I think the linked pull request are reviewed and approved by external contributors, not someone directly related to or included as "contributors" of this project 🙂

@Nevon
Copy link
Member

Nevon commented Sep 29, 2022

It's "maintained" in the sense that I'm still alive, but it's poorly maintained because I'm just one guy who doesn't have enough time and energy to maintain both this library as well as KafkaJS to the level they would need. I don't personally use either of the libraries for anything I do, although the organization I work for does, so if there are any security issues or some other kind of issue that affects my organization's usage that would likely shift my priorities.

I would love to have other users step up and take on more maintenance tasks. It's really not an insignificant amount of work that's required every single week to keep up. You don't need any special permissions to be able to triage issues, discuss proposals and review pull requests. Regarding #197, it doesn't look like people have been reviewing that properly and are using the "approve" button as a "'I want this functionality'-vote button", since no one seems to have found anything to provide feedback on. 😉

If a community member were to display a consistent behavior of quality contributions in the form of triage/reviewing/documenting/debugging, I would be happy to grant them official maintainer status so that they can merge things to master and make releases, once I trust they're not gonna start sending process.env to the FSB or something.

@zion03
Copy link
Author

zion03 commented Sep 30, 2022

Thanks for your answer!

For now, I can confirm that changes in PR help to work with import in protobuf correctly.
I'll check discussion in PR and maybe can help.

And thanks again for your hard work!

@zion03
Copy link
Author

zion03 commented Oct 17, 2022

#197 already merged, so I'm closing this issue.
Thank you very much guys again.

@zion03 zion03 closed this as completed Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants