-
-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define an accessor to get the Host of the endPoint of HTTPRunner #555
Comments
I have one question. Is this functionality necessary because the endpoint is set by environment variables, etc. and is not fixed to one? In most cases, the endpoint should be known by the user executing the runn, so I am cautious about the need for this additional functionality. I think I am wondering if we should have access to the hostname in Perhaps it would be better to make |
I think httpRunners['req'].endpoint would be easier to understand if it were a |
The Some redundancy remained in the area of including default values for environment variables.
https://vscode.dev/github/k1LoW/runn/blob/vulnerability-check/http.go#L47 The current |
👍 Thank you!
I am wondering if this redundancy is acceptable.
I think that is fine if we only consider the However, if we were to add this functionality, I would want to raise the level of abstraction in the form of "access to Runner's settings". At this point, it is debatable whether the parsed value should be set or not. For example, we need to consider the following values.
|
This use case is necessary when sending cookies, but if automatic cookie sending is supported as the next extension, the priority will be lowered.
Agreed. |
For example, it allows access to
We would like to use it in a use case that identifies the domain of the cookie object
The text was updated successfully, but these errors were encountered: