Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show overwritten vars when loop syntax fails #210

Open
k2tzumi opened this issue Oct 16, 2022 · 4 comments
Open

Show overwritten vars when loop syntax fails #210

k2tzumi opened this issue Oct 16, 2022 · 4 comments

Comments

@k2tzumi
Copy link
Collaborator

k2tzumi commented Oct 16, 2022

It might be a good idea to always show the overwritten vars if the debug option was enabled

@k1LoW
Copy link
Owner

k1LoW commented Oct 16, 2022

Is this when it fails? Or is this when the debug option is enabled?

@k2tzumi
Copy link
Collaborator Author

k2tzumi commented Oct 16, 2022

I see the following patterns.

  1. When debugging is enabled
    Always show
  2. If debugging fails with invalid
  3. If debugging is enabled and fails

I am struggling with 1 or 2 above.
Would 1 be simpler in terms of letting the debugging option be utilized?

@k1LoW
Copy link
Owner

k1LoW commented Oct 16, 2022

I don't think the overridden value is the only value we want when we fail. So 2 and 3 may not be suitable as use cases.

If we were to implement it, would it be 1. In that case, it is likely that the Capturer interface will need to be extended.

@k1LoW
Copy link
Owner

k1LoW commented Oct 16, 2022

(For 2 and 3) When they fail, the number of values may be too large.

A good idea for a display would be useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants