Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need test class for the class - FindHttpBasicAuthFinder. #11

Open
sudiptosarkar opened this issue Oct 24, 2017 · 4 comments
Open

Need test class for the class - FindHttpBasicAuthFinder. #11

sudiptosarkar opened this issue Oct 24, 2017 · 4 comments

Comments

@sudiptosarkar
Copy link
Member

Yes, I know the class name needs refactor. We need a test class made for this class.
Tests should not make real calls. Instead, calls must be mocked with Mockito and/or PowerMockito.
Examples of the testing pattern can be found in the other three dependency repos mentioned in the README.md.

@cyterdan
Copy link

Hi !

I'd like to start working on this.

@sudiptosarkar
Copy link
Member Author

@cyterdan Sure... Go ahead. Raise a Pull Request when you're done and put me on review... 🙂

@cyterdan
Copy link

Seems there is an infinite loop when google is not reachable, is that by design ?

@sudiptosarkar
Copy link
Member Author

@cyterdan Yes. That's for resiliency. If the attacking system's Internet goes down, it will wait till it's back up... Also because my Internet connection sucked when I wrote it... 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants