Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unnecessary modifications are made #117

Open
jzbrooks opened this issue Dec 6, 2024 · 0 comments
Open

Unnecessary modifications are made #117

jzbrooks opened this issue Dec 6, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@jzbrooks
Copy link
Owner

jzbrooks commented Dec 6, 2024

Describe the bug
This path modifies an absolute command to become relative and toggles back and forth between the two on subsequent runs. This creates git history noise. The command should ideally only be modified if it is a net positive benefit, and modification should be avoided if two options are the same length

 <vector xmlns:android="http://schemas.android.com/apk/res/android" android:height="24dp" android:viewportHeight="24" android:viewportWidth="41" android:width="41dp">
-  <path android:fillColor="#ff3008" android:pathData="M39.043,6.335a10.182,10.182,0,0,0,-9.008-5.429H1.558C1.01,0.906 0.59,1.361 0.59,1.913c0,0.26 0.097,0.52 0.29,0.683L7.079,8.87a2.926,2.926,0,0,0,2.067,0.878h20.082c1.421,0 2.615,1.138 2.615,2.568 0,1.431-1.13,2.634-2.55,2.634H15.442c-0.549,0-0.969,0.455-0.969,1.007 0,0.26 0.097,0.521 0.291,0.683l6.166,6.274a2.926,2.926,0,0,0,2.067,0.878h6.263c8.169,0 14.336-8.777 9.783-17.457Z"/>
+  <path android:fillColor="#ff3008" android:pathData="M39.043,6.335a10.182,10.182,0,0,0,-9.008-5.429H1.558c-0.548-0-0.968,0.455-0.968,1.007 0,0.26 0.097,0.52 0.29,0.683L7.079,8.87a2.926,2.926,0,0,0,2.067,0.878h20.082c1.421,0 2.615,1.138 2.615,2.568 0,1.431-1.13,2.634-2.55,2.634H15.442c-0.549,0-0.969,0.455-0.969,1.007 0,0.26 0.097,0.521 0.291,0.683l6.166,6.274a2.926,2.926,0,0,0,2.067,0.878h6.263c8.169,0 14.336-8.777 9.783-17.457Z"/>

The command

-C1.01,0.906 0.59,1.361 0.59,1.913c0,0.26 0.097,0.52 0.29,0.683
+c-0.548-0-0.968,0.455-0.968,1.007 0,0.26 0.097,0.52 0.29,0.683

vgo version
3.0

Visual Comparison
There's no visual difference

Additional context
Add any other context about the problem here.

@jzbrooks jzbrooks added the bug Something isn't working label Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant