Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Squad method refers to mp_spent, sp_spent, which are not in Squad or any of its base classes #63

Open
AmkG opened this issue Apr 28, 2020 · 1 comment

Comments

@AmkG
Copy link
Contributor

AmkG commented Apr 28, 2020

mp_spent and sp_spent are initialized only in class Being:

gearhead-caramel/gears/base.py

Lines 3179 to 3180 in 32a0b43

self.mp_spent = 0
self.sp_spent = 0

Only Character seems to derive from Being. class Squad derives from BaseGear, not Being.

These methods in Squad refer to mp_spent and sp_spent:

gearhead-caramel/gears/base.py

Lines 3631 to 3641 in 32a0b43

def get_current_mental(self):
return max(self.get_max_mental() - self.mp_spent, 0)
def get_current_stamina(self):
return max(self.get_max_stamina() - self.sp_spent, 0)
def spend_mental(self, amount):
self.mp_spent += amount
def spend_stamina(self, amount):
self.sp_spent += amount

It looks to me that Squad is not used currently, so maybe it is a "TODO" class?

@jwvhewitt
Copy link
Owner

You are correct, Squad is not currently being used. I was planning to use it for the player's lance on the world map and possibly also for fighting teams of human scale combatants in mecha combat (power armor like the Strongarm and Badger, or biomonsters).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants