Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double champion #158

Open
AmkG opened this issue Jul 31, 2020 · 4 comments
Open

Double champion #158

AmkG opened this issue Jul 31, 2020 · 4 comments

Comments

@AmkG
Copy link
Contributor

AmkG commented Jul 31, 2020

Screenshot from 2020-07-31 16-42-06

Savefile: rpg_Colemaia.sav.zip

I know champions are popular but this is a bit ----

@jwvhewitt
Copy link
Owner

My guess: Major NPCs now get custom mecha by default, so if an encounter featuring one goes through the encounter championifier their mecha might get doubly customized. I will look into this.

@AmkG
Copy link
Contributor Author

AmkG commented Jul 31, 2020

My guess as well. Fortunately gears.champions.upgrade_to_champion already adds a True attribute is_champion, we could just add this to upgrade_to_champion:

    if hasattr(mek, 'is_champion') and mek.is_champion:
        return mek

@AmkG
Copy link
Contributor Author

AmkG commented Sep 2, 2020

I haven't seen this double-champion thing occurring recently, but I also noticed that major NPCs seem to change their champion types now. Hmm.

@AmkG
Copy link
Contributor Author

AmkG commented Sep 2, 2020

Spoke too soon...

Screenshot from 2020-09-02 17-13-48

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants