Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In "Historic Site" plot, quest-giver seems to blame player for destroying tomb if player used Science on it. #98

Open
AmkG opened this issue Mar 4, 2019 · 0 comments

Comments

@AmkG
Copy link

AmkG commented Mar 4, 2019

If the player performs Science on the tomb, the quest giver says there is no point now since the tomb has been destroyed. However, this seems to be a fluke.

This is the code that executes when the quest giver is contacted after the player has performed Science on the tomb and cleared the monsters:

greeting <NewChat if= P4 3 else GoCheckLoss Say d3 AddReact d12 Memo 0 DeleteKeyItem E3 if= P3 1 else GoJustEnd S= 203 P2 Goto GoDelete>

Plot variable P3 is set to 1 when Science is performed on the tomb.

Clue29 <ifG PCSkillVal 29 V4 else GoDid Mental V= 4 PCSkillVal 29 ifG SkRoll 29 10 else GoNoSolve V= 3 1 Print 1 XPV 100 Trigger KEY SelfNID>

Plot variable P4 is set to 3 if the monsters were cleared:

nu2 <if= T2 0 if= V4 1 V= 4 3 Reputation 6 1 XPV 50 S= 201 0 S+ 202 1 S= 205 ComTime S+ 205 13800 N= 2 E2 Print 101>

If P3 = 1 and P4 = 3 then the code below is what gets executed from greeting:

Say d3 AddReact d12 Memo 0 DeleteKeyItem E3 S= 203 P2 Goto GoDelete

However GoDelete includes Say 101 which overwrites the earlier Say d3:

GoDelete <Say 101 S= 201 0 AdvancePlot 0>

It should probably be corrected:

GoCheckMission <if= V1 1 else GoCheckFirst ifItemOK E3 else GoMonolithDestroyed Say 105 Goto GoAddComOps>
GoMonolithDestroyed <Say 101 Goto GoDelete>
GoDelete <S= 201 0 AdvancePlot 0>

But that's arguably not enough. As-is, if the monsters are cleared but the monolith is destroyed (with the player not performing Science on it) the quest-giver will still treat it as a success. The greeting probably needs to be rewritten to properly handle all cases, in the order "mission failed" "monolith destroyed" "mission succeeded".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant