Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package cleanup: React and Underscore #51

Open
jadbox opened this issue Feb 12, 2016 · 1 comment
Open

Package cleanup: React and Underscore #51

jadbox opened this issue Feb 12, 2016 · 1 comment

Comments

@jadbox
Copy link

jadbox commented Feb 12, 2016

It seems these libraries are not needed and would significantly reduce the size of the UMD builds I believe. React/react-dom looks largely unneeded, and since Underscore is only used for its events, it can be replaced with eventemitter3.

Also, babelify can be a dev-dependency instead of a top level package dep. Underscore can be replaced with the faster lodash4.

"dependencies": {
    "babelify": "^7.2.0",
...
    "backbone": "^1.2.3",
...
    "react": "^0.14.3",
    "react-dom": "^0.14.3",
    "underscore": "^1.8.3"
  }
@jadbox jadbox changed the title Remove React and Underscore Package cleanup: React and Underscore Feb 12, 2016
@go-oleg
Copy link
Contributor

go-oleg commented Feb 17, 2016

@jadbox, thx for pointing these out.

  • babelify: moving to devDependencies in package.json: move babelify into devDependencies #57
  • eventemitter3: yes, this is something that makes sense to do
  • lodash: yes, this is something that makes sense to do
  • react: The Less view which is implemented here uses react. The fact that we package this specific set of views is largely a relic of the Jut 1.0 product. Whereas we probably will continue pushing all of these into juttle-engine/juttle-client-library, we can create a separate UMD build for each view so that you would only pull in the ones you want (e.g. the timechart UMD won't have react bundled in it). How does that sound?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants