You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It seems these libraries are not needed and would significantly reduce the size of the UMD builds I believe. React/react-dom looks largely unneeded, and since Underscore is only used for its events, it can be replaced with eventemitter3.
Also, babelify can be a dev-dependency instead of a top level package dep. Underscore can be replaced with the faster lodash4.
eventemitter3: yes, this is something that makes sense to do
lodash: yes, this is something that makes sense to do
react: The Less view which is implemented here uses react. The fact that we package this specific set of views is largely a relic of the Jut 1.0 product. Whereas we probably will continue pushing all of these into juttle-engine/juttle-client-library, we can create a separate UMD build for each view so that you would only pull in the ones you want (e.g. the timechart UMD won't have react bundled in it). How does that sound?
It seems these libraries are not needed and would significantly reduce the size of the UMD builds I believe. React/react-dom looks largely unneeded, and since Underscore is only used for its events, it can be replaced with eventemitter3.
Also, babelify can be a dev-dependency instead of a top level package dep. Underscore can be replaced with the faster lodash4.
The text was updated successfully, but these errors were encountered: