Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize memory allocation for symbols #515

Open
justinethier opened this issue Nov 28, 2023 · 0 comments
Open

Optimize memory allocation for symbols #515

justinethier opened this issue Nov 28, 2023 · 0 comments

Comments

@justinethier
Copy link
Owner

It seems like the strdup and memcpy are doing the same work twice for name. Is there a more efficient way to implement this, in terms of both CPU and memory?

static object add_symbol_by_name(const char *name)                                                                                            
{                                                                                
  symbol_type sym = { {0}, symbol_tag, _strdup(name)};                           
  symbol_type *psym = malloc(sizeof(symbol_type));                                                                                            
  memcpy(psym, &sym, sizeof(symbol_type));                                       
  return add_symbol(psym);                                                       
} 
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant