-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pie-storybook): DSW-2593 improve logic for conditional rendering of stories #2088
Conversation
🦋 Changeset detectedLatest commit: ff40cf7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
f20e485
to
ab693aa
Compare
8f6ec2b
to
39f9f9f
Compare
f013255
to
faeb870
Compare
b9f492e
to
6ff9eb6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good, but please can you write up some documentation before merging? Basically how do we write stories and where, with this new approach and explain when and how to use each, I think.
e955c28
As discussed, this has already be done, and will be improved futher at the end of this epic 👍🏼 |
Describe your changes (can list changeset entries if preferable)
This PR aims to improve the logic for the conditional rendering of stories. Previously, only stories with the
.test.stories.ts
extension were rendered in the new Storybook Testing deployment.With this PR, we've introduced test specific stories in
pie-storybook/stories/testing
as we look to migrate more of our tests to use Storybook for the testbed.Component Variant Stories
A new
createVariantStory
has been introduced to replicate the functionality of the oldWebComponentTestWrapper
.Storybook example here
@justeattakeaway/generator-pie-component
Docs - https://github.com/justeattakeaway/pie/wiki/Testing-of-PIE-Components
Author Checklist (complete before requesting a review)
PIE Storybook
/PIE Docs
PR previewReviewer checklists (complete before approving)
Reviewer 1 - @fernandofranca
PIE Storybook
/PIE Docs
PR previewReviewer 2 - @jamieomaguire
PIE Storybook
/PIE Docs
PR preview