CONTRIBUTING.md

Contributing

Welcome! As a Jupyter project, you can follow the Jupyter contributor guide.

Make sure to also follow Project Jupyter's Code of Conduct for a friendly and welcoming collaborative environment.

This guide was adapted from the contributing guide in the main jupyterhub repo.

Setting up a development environment

As a Python project, a development install of JupyterHub follows standard practices for installation and testing.

Note: if you have Docker installed locally, you can run all of the subsequent commands inside of a container after you run the following initial commands:

# starts an openldap server inside a docker container
./ci/docker-ldap.sh

# starts a python docker image
docker run --rm -it -v $PWD:/usr/local/src --workdir=/usr/local/src --net=host python:3.11 bash

1. Do a development install with pip

   pip install --editable ".[test]"

2. Set up pre-commit hooks for automatic code formatting, etc.

   pip install pre-commit
   
   pre-commit install --install-hooks

   You can also invoke the pre-commit hook manually at any time with

   pre-commit run

To clean up your development LDAP deployment, run:

docker rm -f test-openldap

Testing

It's a good idea to write tests to exercise any new features, or that trigger any bugs that you have fixed to catch regressions.

You can run the tests with:

# starts an openldap server inside a docker container
./ci/docker-ldap.sh

# run tests
pytest

The tests live in ldapauthenticator/tests.

When writing a new test, there should usually be a test of similar functionality already written and related tests should be added nearby.

When in doubt, feel free to ask.