Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update Juju environment variable assignments #613

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gfouillet
Copy link

Description

<Please provide a description of this PR. What, why, when, how, where, who?>

Fixes:

Type of change

<What type of a change is this? Please keep one or more relevant lines from below and delete the others.>

  • Add new resource
  • Change existing resource
  • Logic changes in resources (the API interaction with Juju has been changed)
  • Change in tests (one or several tests have been changed)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Requires a documentation update
  • Maintenance work (repository related, like Github actions, or revving the Go version, etc.)
  • Other (please describe)

Environment

  • Juju controller version:

  • Terraform version:

QA steps

Manual QA steps should be done to test this PR.

provider juju {}
...

Additional notes

<Please add relevant notes & information, links to mattermost chats, other related issues/PRs, anything to help understand and QA the PR.>

@gfouillet gfouillet force-pushed the ci/handle-ipv6-controller-ip-addresses branch 5 times, most recently from 298b71b to 0391513 Compare October 21, 2024 12:18
Updated Juju environment variable assignments for consistency and correctness in various workflow
files and documentation.

- Before this commit, the environment variable assignments were inconsistent and used mixed
  formatting, including usage of `tr` command instead of relying on `raw` option for `yq` output
- After this commit, the assignments are consistent across all files, and we rely more on `yq`
  option to get the expected result, improving the readability and reducing the likelihood of
  errors.
@gfouillet gfouillet force-pushed the ci/handle-ipv6-controller-ip-addresses branch from 0391513 to e76c16f Compare October 21, 2024 15:27
@gfouillet gfouillet changed the title fix: fix possible IPv6 issue in canary test. fix: update Juju environment variable assignments Oct 21, 2024
@hmlanigan hmlanigan added the state/codefreeze this pr cannot land until the code freeze has lifted. label Oct 22, 2024
@alesstimec alesstimec removed the state/codefreeze this pr cannot land until the code freeze has lifted. label Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants