-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add juju_access_offer schema #627
Comments
Overall this look good, thank you for the detail. I'm unsure of I just noticed that the I'd prefer to have improved behavior rather than repeating mistakes made in |
In that case, the resource would need to check during the update whether a grant or revoke should be run, right? For example, if the access level is initially 'admin' and then changes to 'read', the provider should call 'revoke' instead of 'grant'. |
Hi, although the issue was not closed, I started working on a draft PR that is now ready for review. While working on it, I noticed why Access was set to RequiresReplace: it changes the ID, and without it, the update fails. I’ve marked the PR as ready for review, but if there are any updates on this issue, I can revert it back to a draft. |
Considering what was discussed in the last terraform office hours, this is a proposal for a new schema: Thanks @alesstimec for the idea.
|
this look ok to me, but is it possible to validate that a specific user only appears in one of the sets? |
Actually I can write a validateconfig for that. |
Type of change
Adding new schema
Description
Details
Example terraform plan
Notes & References
This schema is a step for providing CMR via Juju Terraform Provider. It was discussed in the last sprint (Oct/2024).
When removing/changing a juju_access_offer we should have in mind that revoke does not remove all access levels as per the documentation example:
The text was updated successfully, but these errors were encountered: