Certain mangas won't open properly. (Something to do with file size?)

[ThoughtfulSenpai]

Hi. Great app. Thanks for your work. It is very appreciated. I've recommended your app to various learners. Anyway.
I read through the issues and could not find something about this issue, so I'm gonna open this ticket.

• First of all,
  this is not new. This is an issue I've noticed a while ago. Since the first release from AppStore. But, just recently I decided that I should open the ticket.

• This issue affects both iPad and Mac. I don't know if it affects iPhone, but I guess its likely, since it's the same code.

• It happens with specific mangas. Most mangas open just fine. It's just some of them. I haven't been able to identify a reason, but it happens with .zip and .rar (cbz, cbr) alike, and .jpg and .png alike.

Description of the issue.

1. You try to load a manga.
   option a) Takes forever to fetch the item. In the end, it never loads, and the import window closes. Apparently the item is downloaded to the app (it appears via the server, but it does not import to the home view)

option b)You load a manga. It "imports" it "normally". But item appears like this:

Then,

And the real problem ensues. You open the manga and find that randomly some pages are loaded and some aren't. Some pages will render like this permanently. No matter how long you wait, it won't render. If you flick through the pages, some are loaded correctly (yet sometimes out of order), and some are rendered as black emptiness.

So, this is the issue. I've tried to find a reason, but haven't been able to find the culprit.
Most likely, I guess, it has to do with either resolution of the pages or size of the images, or size of the total file, because that seems to be a good predictor. If manga is too heavy, chances are it won't load. I've tried reencoding images with ImageMagick to reimport and that sometimes works, sometimes it does not. As I said, it affects .jpg and .png.
Worth noting that such mangas open just normally with any other comic reader app on both Mac and iPad, so they are fine.

Any hints, any fixes, anything?
Will try to see if I can pin point the issue.

Update:
Im trying to get the project running for development, but have been running into issues with cocoapods. apparently is an Applesilicon issue. If I can get the project running on AppleSilicon, I might have a chance at solving this issue on File Extraction. Are you coding on intel?

[juanj]

Thanks for reporting this issue!

The first thing that comes to my mind is that maybe there are some extra files inside the zip/cbz. The app expects the contents to be images only. So, if, for example, there is a .DS_Store file, or any other non-image file, it can cause problems.

Can you check the file list of one of the mangas that is having this issue? You can do so by opening a terminal and using the command unzip -l <path of the manga>

[juanj]

Are you coding on intel?

I started developing the app on an Intel mac, but now I'm using an M1. The fixes for compiling it on an M1 were not yet on development, but should be good to go now.

If you want to give it a go on trying to figure out the issue, you probably want to look into CBZReader.swift and MangaDataSource.swift