Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terminal tab does not support suid binaries. #134

Open
yacc143 opened this issue Jul 13, 2020 · 3 comments
Open

Terminal tab does not support suid binaries. #134

yacc143 opened this issue Jul 13, 2020 · 3 comments

Comments

@yacc143
Copy link

yacc143 commented Jul 13, 2020

terminal tab on Atom 1.48.0 (deb installed on Ubuntu 1.48.0) does not support suid binaries:

spawn a fresh terminal:

andreas@obelix:~/work/grants_team_setup$ LANG=C
andreas@obelix:~/work/grants_team_setup$ sudo
sudo: effective uid is not 0, is /usr/bin/sudo on a file system with the 'nosuid' option set or an NFS file system without root privileges?
andreas@obelix:~/work/grants_team_setup$ 

capsh --print reports the same inside and outside Atom.

Even funnier, running gnome-terminal inside the tab, starts a new terminal, and that DOES support executing suid binaries like sudo.

@yacc143
Copy link
Author

yacc143 commented Jul 13, 2020

Ah, found the potential issue here:

electron/electron#18521

Could it be a similar problem here? Considering that terminal tab also depends upon node-pty?

@yacc143
Copy link
Author

yacc143 commented Jul 13, 2020

And yes, running gnome-terminal would work because gnome-terminal probably forks of a mother process that is outside of atom.

@yacc143
Copy link
Author

yacc143 commented Jul 13, 2020

Yep, this is a known bug in Electron 5.0.x :(

And looking at the tags on the issue/commit, it will only be fixed in 5.1.x

electron/electron#19953

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant