Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customize TERM variable option #128

Open
BDMorrell opened this issue Mar 17, 2020 · 2 comments
Open

Customize TERM variable option #128

BDMorrell opened this issue Mar 17, 2020 · 2 comments

Comments

@BDMorrell
Copy link

Can we have a way to declare which terminal we're using?

Most of my terminal colors don't work with the default xterm-color, and it seems that xterm-256color is supported by this addon:

this seems like a hack to me

I'm using

  • zsh "z shell" (technically with the "oh my zsh" addon, and themed with p10k)
  • macOS 10.15.3

Thank you! Great addon, by the way!

@jsmecham
Copy link
Owner

Curious if there's any harm in just defaulting to xterm-256color? I'd like to avoid adding options and settings, if possible, as my goal for this addon is to work out of the box for most people without thinking about configuration.

@BDMorrell
Copy link
Author

Doing some research, it seems that TERM=xterm-256color should be okay. I haven't found anything that would say otherwise.

While we're at it, why not set COLORTERM=truecolor? I would say it's supported because of xtermjs/xterm.js#1895.

I also found an article about terminal colors.

I don't quite know how to set these variables accurately, but it seems that it would have to do with lib/terminal-session:

return spawnPty(this.shellPath, shellArguments, {
name: 'xterm-color',
env: this.sanitizedEnvironment,
cwd: this.workingDirectory
});

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants