Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameter type validation for JSDuck should allow '/' as well as '|' as a value seperator #135

Open
jdforrester opened this issue Aug 4, 2015 · 3 comments

Comments

@jdforrester
Copy link

Per the JSDuck documentation, values can be separated by either '|' or '/'. However, only the first of these works.

@qfox qfox added the bug label Aug 4, 2015
@qfox
Copy link
Member

qfox commented Aug 4, 2015

Thanks, nice catch!

Whichever you choose, be consistent within your project.

Need to make some option for types parsing algorithm to use '/' instead of '|'. What you think if we just replace '/' to '|' for JSDuck (or if option is set)?

@jdforrester
Copy link
Author

Need to make some option for types parsing algorithm to use '/' instead of '|'. What you think if we just replace '/' to '|' for JSDuck (or if option is set)?

We use '|' not '/' (I only noticed it when looking for other issues ;-)), so I'd love not only understanding both (which to looks like jsdoctypeparser/jsdoctypeparser#21 fixes) but having the style enforce one or the other for consistency, yeah – but should that be a follow-up (wishlist) issue?

@qfox
Copy link
Member

qfox commented Aug 5, 2015

@jdforrester Yeah, thanks for clarifying that. For now it looks like complicated task cuz we also need some info about used delimiter to check it. Don't see how to check it easily with regexps or something else. Anyway, it's a good idea ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants