Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No Sass / Node build test #62

Open
ameliabradley opened this issue Aug 7, 2017 · 0 comments
Open

No Sass / Node build test #62

ameliabradley opened this issue Aug 7, 2017 · 0 comments

Comments

@ameliabradley
Copy link
Collaborator

I've considered adding a Node build test to Linfo. For now it could just do a sanity check that the Sass and JavaScript compile correctly. Later it could do more complicated things (like running eslint or JS unit tests.)

But while TravisCI has excellent support for both PHP and Node, the way the .travis.yml test matrix works we'd end up running the Node build test on every one of our PHP unit test platforms. This doesn't add much to our build time. It just seems unnecessary and inefficient.

We could use a different testing framework for the Node compilation. There's Semaphore. I don't consider it particularly ideal to have two CI platforms, but I guess GitHub supports it.

Ideally though, someone with more TravisCI experience can prove me wrong here!

Thoughts? Suggestions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant