Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

should references to JSHINT be updated in favor ESLINT ? #155

Closed
michange opened this issue Dec 22, 2016 · 5 comments
Closed

should references to JSHINT be updated in favor ESLINT ? #155

michange opened this issue Dec 22, 2016 · 5 comments

Comments

@michange
Copy link

The former can't be seen on jq core github. I can't see any .jshintrc file in the source.

So i can't grasp the instructions at :
https://contribute.jquery.org/style-guide/js/#linting

What should I do in order to lint correctly ?

@mgol
Copy link
Member

mgol commented Dec 23, 2016

jQuery Core & QUnit has switched from JSHint+JSCS to ESLint with the jquery config; I don't know what are plans of other projects (jQuery UI, jQuery Mobile, PEP).

Perhaps we should mention both then, at least for the time being. @scottgonzalez, @arschmitz, do you plan to switch other projects eventually? If so, maybe it'd be best to emphasize ESLint and only mention that some projects still use JSHint.

@scottgonzalez
Copy link
Member

We plan on switching jQuery UI to standard.

@michange
Copy link
Author

Thanks a lot.

I think the ESLint 'jquery' config mentioned by mgol does not check the whole guide, i.e. the multi-line chain of method calls.

Maybe a little cookbook should be provided on that topic?

@mgol
Copy link
Member

mgol commented Dec 29, 2016

I think the ESLint 'jquery' config mentioned by mgol does not check the whole guide, i.e. the multi-line chain of method calls.

Maybe a little cookbook should be provided on that topic?

This is already mentioned at https://contribute.jquery.org/style-guide/js/#chained-method-calls. It's true we don't validate everything but it's often a side-effect of our tools not being able to do it all for us.

That said, considering @scottgonzalez's reply, various jQuery projects will use incompatible code styles so we should perhaps just remove the whole JSHint description in favor of a short info that each project uses their own linter and that running npm test should, among other things, fire up the linter.

@dmethvin
Copy link
Member

Moved to jquery/contribute.jquery.org#141

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

4 participants