Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contributing Code page #6

Open
ajpiano opened this issue Dec 13, 2012 · 7 comments
Open

Contributing Code page #6

ajpiano opened this issue Dec 13, 2012 · 7 comments

Comments

@ajpiano
Copy link
Member

ajpiano commented Dec 13, 2012

In page/code.md, following the mold of the triage page, put together instructions on the basics of contributing code to any jQuery project, e.g., forking repos, making pull requests, writing tests, not removing tests, following the style guide, using grunt, etc, with links to all the project repos.

This should probably link to the Won't Fix page, among other things as well.

@ghost ghost assigned dmethvin Jan 9, 2013
@ajpiano
Copy link
Member Author

ajpiano commented Jan 11, 2013

I created the Commits and Pull Requests page to explain how we expect people to run their forks and do their commits - this page can reference that heavily

@dmethvin
Copy link
Member

This page could use some more work so I'm leaving this open, but I think it's good enough for release.

@ajpiano
Copy link
Member Author

ajpiano commented Jan 18, 2013

confirm, @dmethvin. though i guess we should capture what improvements we want to make in this ticket, or close it and do separate issues

@dmethvin
Copy link
Member

I want to capture some of the things you mentioned above that aren't in there yet, and add links to the code bug/issue trackers.

@ajpiano
Copy link
Member Author

ajpiano commented Jan 18, 2013

okey doke

@arthurvr
Copy link
Member

@dmethvin You ever got assigned to this ticket, are you planning to pick it up or do you want anybody else to do it?

and add links to the code bug/issue trackers.

We already do have a list of the bug trackers.

using grunt,

The workflow of how build systems and testing workflow works is very different project specific, so this probably should just be documented project per project separately. For the websites it's all the same workflow, but we do already have guidelines around that.

@dmethvin
Copy link
Member

dmethvin commented Aug 5, 2015

@arthurvr if someone else wanted to pick this up (or just close it if you feel like it's all covered elsewhere) that would be great!

@dmethvin dmethvin removed their assignment Aug 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants