-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document how to be a maintainer #27
Comments
I am really interested on this one. The gist text is totally useful. 👍 |
Looks like we already have a page for maintainers that was created after this issue was created. https://github.com/jquery/contribute.jquery.org/blob/master/pages/repo-maintainers-guide.md My question is should this be linked up somewhere on the site. I had no idea this was available and just had a conversation with @dmethvin about documenting the proper way of how to do a PR merge when I found this page in the repo. cc: @scottgonzalez |
It's part of https://github.com/jquery/foundation/wiki/HOWTO-add-a-team-member (last item). |
That's silly why are we hiding this kind of documentation? There doesn't seem to be anything there that's "confidential" Technically only new team members will be exposed to this info and existing team members potentially have no idea it exists. I'd love to see this linked up from somewhere to make it more accessible. |
If everyone agrees, I'll be happy to think of a way to link this and any other documents deemed worthy for improved visibility. |
With "link" you mean to just put it online somewhere else right? Just because if you just link to private repos nobody can't open it even. |
It's not about it being confidential, it's about not confusing new contributors. There's obviously nothing confidential, it's a public page and it shows up in search results. Where exactly should we would put a link to this that wouldn't confuse new contributors? |
I have two thoughts:
|
@RedWolves @scottgonzalez @arthurvr How about adding a new heading in the left nav with the title "For maintainers..." just trying to keep it consistent with the existing tone on this menu... |
That looks good to me. Regarding https://github.com/jquery/contribute.jquery.org/blob/master/pages/repo-maintainers-guide.md - we can heavily simplify the CLA section, now that its mostly automated. // Nevermind, Anne already logged that as #115 |
Seems fine to me. |
We provide information for contributors, but nothing for maintainers. While we don't add people to jQuery Core, we should generally give out more write access to spread the load. I've never seen anyone abuse that "power", while they usually become more engaged in the project, since they now have more authority and try to make that up in the necessary responsibility.
I've started putting together some guidelines for reviewing PRs, should be valid at least for QUnit and mostly jQuery UI: https://gist.github.com/jzaefferer/a93958b48faa55ff84c5
Do we just give maintainers read access to the CLA document? Or is there some other option?
The text was updated successfully, but these errors were encountered: