Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document how to be a maintainer #27

Closed
jzaefferer opened this issue Mar 3, 2013 · 12 comments
Closed

Document how to be a maintainer #27

jzaefferer opened this issue Mar 3, 2013 · 12 comments

Comments

@jzaefferer
Copy link
Member

We provide information for contributors, but nothing for maintainers. While we don't add people to jQuery Core, we should generally give out more write access to spread the load. I've never seen anyone abuse that "power", while they usually become more engaged in the project, since they now have more authority and try to make that up in the necessary responsibility.

I've started putting together some guidelines for reviewing PRs, should be valid at least for QUnit and mostly jQuery UI: https://gist.github.com/jzaefferer/a93958b48faa55ff84c5

Do we just give maintainers read access to the CLA document? Or is there some other option?

@leobalter
Copy link
Member

I am really interested on this one. The gist text is totally useful. 👍

@RedWolves
Copy link
Member

Looks like we already have a page for maintainers that was created after this issue was created.

https://github.com/jquery/contribute.jquery.org/blob/master/pages/repo-maintainers-guide.md

My question is should this be linked up somewhere on the site. I had no idea this was available and just had a conversation with @dmethvin about documenting the proper way of how to do a PR merge when I found this page in the repo.

cc: @scottgonzalez

@agcolom
Copy link
Member

agcolom commented Dec 24, 2014

It's part of https://github.com/jquery/foundation/wiki/HOWTO-add-a-team-member (last item).
@scottgonzalez pointed it out to me recently.

@RedWolves
Copy link
Member

That's silly why are we hiding this kind of documentation? There doesn't seem to be anything there that's "confidential" Technically only new team members will be exposed to this info and existing team members potentially have no idea it exists.

I'd love to see this linked up from somewhere to make it more accessible.

@agcolom
Copy link
Member

agcolom commented Dec 24, 2014

If everyone agrees, I'll be happy to think of a way to link this and any other documents deemed worthy for improved visibility.

@arthurvr
Copy link
Member

With "link" you mean to just put it online somewhere else right? Just because if you just link to private repos nobody can't open it even.

@scottgonzalez
Copy link
Member

It's not about it being confidential, it's about not confusing new contributors. There's obviously nothing confidential, it's a public page and it shows up in search results. Where exactly should we would put a link to this that wouldn't confuse new contributors?

@scottgonzalez
Copy link
Member

@arthurvr The list that @agcolom provided doesn't need to be linked from anywhere and doesn't need to be public, that's not what's being discussed.

@RedWolves
Copy link
Member

I have two thoughts:

  1. A link in the left nav called Repository Maintainers
  2. A section at the bottom of http://contribute.jquery.org/open-source/ called Repository Maintainers with a little content to describe who a maintainer is and a link to the page.

@agcolom
Copy link
Member

agcolom commented Apr 21, 2015

@RedWolves @scottgonzalez @arthurvr How about adding a new heading in the left nav with the title "For maintainers..." just trying to keep it consistent with the existing tone on this menu...
proposedmenu

@jzaefferer
Copy link
Member Author

That looks good to me.

Regarding https://github.com/jquery/contribute.jquery.org/blob/master/pages/repo-maintainers-guide.md - we can heavily simplify the CLA section, now that its mostly automated.

// Nevermind, Anne already logged that as #115

@scottgonzalez
Copy link
Member

Seems fine to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

6 participants